Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configurable staging repository description #63

Closed

Conversation

akomakom
Copy link

my company relies on staging repository description for various cleanup jobs, so blindly setting them to "Automatically released/promoted with gradle-nexus-staging-plugin!" isn't always ideal.

I didn't add any tests because I couldn't figure out how to test this with wiremock - the best I could do was verify that the RepositoryCloser instance had the right description set in its field (which seemed kind of weak), so I didn't include that in this PR. Suggestions are welcome.

@akomakom
Copy link
Author

Test failures appear to be environment-related, not up to me to fix.

@szpak szpak force-pushed the add-repository-description-setter branch from 79ecfbb to 3247e1b Compare August 17, 2017 20:31
@szpak
Copy link
Member

szpak commented Aug 17, 2017

@akomakom Thanks for your contribution. I merged it manually and slightly refactored. It's available in just automatically released version 0.10.0.

Btw, I will leave this PR open for a time being to try to find a workaround for the issue with PGP key not available in PR builds on Travis.

@szpak szpak added this to the 0.10.0 milestone Aug 18, 2017
@szpak
Copy link
Member

szpak commented Aug 18, 2017

Btw, add your email address you used in the commit to your GitHub account to be listed on the contributors page.

@szpak szpak force-pushed the add-repository-description-setter branch from 9b29ac5 to b8c7321 Compare August 18, 2017 12:04
@akomakom
Copy link
Author

@szpak thanks for bringing this to my attention, I had user.email set all wrong on my 200 random work/non-work related repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants