This repository has been archived by the owner on Oct 26, 2020. It is now read-only.
Shahd week 8 #1003
Closed
Shahd week 8 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2020 22:57
|
I think you were meant to write down some answers to exercise 1 as well :) |
msachi
reviewed
Jul 4, 2020
| @@ -17,10 +17,12 @@ Open index.html in your browser. Every time you refresh the page, | |||
| a different greeting should be displayed in the box. | |||
| */ | |||
|
|
|||
| fetch('*** Write the API address here ***') | |||
| fetch("https://codeyourfuture.herokuapp.com/api/greetings") | |||
| const li = document.createElement("li"); | ||
| const myImg = document.createElement("img"); | ||
|
|
||
| function displayer(){ |
| fetch("https://dog.ceo/api/breeds/image/random") | ||
| .then(response => response.json()) | ||
| .then(data => data.message) | ||
| .then(function (img){ |
There was a problem hiding this comment.
Try to stick to the same function format (e.g. arrow functions) for consistency.
| ul.appendChild(li); | ||
| myImg.src = img; | ||
| }) | ||
| .catch(err => console.error(err)); |
There was a problem hiding this comment.
How about error handling? Could you do something more than just console.log it?
| div.appendChild(img); | ||
| img.src = myData; | ||
| }) | ||
| .catch(anyErr => console.error(anyErr)); |
There was a problem hiding this comment.
Again, think about error handling. What could you display to the user?
| const div = document.getElementById("container"); | ||
| const img = document.createElement("img"); | ||
|
|
||
| function fether(){ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name:
Your City:
Your Slack Name:
Homework Details
Module:
Week: