Sheffield | 25-ITP-SEP | Jak Rhodes-Smith | Sprint 2 | coursework/sprint-2 #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakr-s
added
the
Needs Review
cjyuan
added
the
Review in progress
cjyuan
reviewed
Oct 8, 2025
Comment on lines
+18
to
+19
| return (weight / height ** 2).toFixed(1); | ||
| } |
There was a problem hiding this comment.
What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect?
Comment on lines
+29
to
+30
| const outMidnight = formatAs12HourClock("00:00"); | ||
| const targetMidnight = "00:00 am"; |
There was a problem hiding this comment.
00:00 should be equivalent to 12:00 am.
Comment on lines
+69
to
+74
| const out1 = formatAs12HourClock("01:00"); | ||
| const target1 = "01:00 am"; | ||
| console.assert( | ||
| out1 === target1, | ||
| `current output: ${out1}, target output: ${target1}` | ||
| ); |
There was a problem hiding this comment.
Some return values are padded with zeroes and some aren't.
It would be better to make the format more consistent.
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all tasks for sprint 2