NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-implement-and-rewrite #709
Conversation
…ixed the conflict with a new variable name
…wer case to upper case and replace all space with underline
…toPounds with input condition checks
TzeMingHo
added
📅 Sprint 3
jenny-alexander
added
Review in progress
There was a problem hiding this comment.
Good job covering most test cases @TzeMingHo - I left a few comments for you to review.
| // complete the rest of the tests and cases | ||
| // write one test at a time, and make it pass, build your solution up methodically | ||
|
|
||
| function isProperFraction(numerator, denominator) { |
There was a problem hiding this comment.
Your isProperFraction works well. However, if you wanted to simplify it even more, you could try:
// this will return either true or false
return (Math.abs(numerator) < Math.abs(denominator));
There was a problem hiding this comment.
What would happen if I run the test with:
- angle: 'ten'
- angle: 1000
- angle: -22
- angle: null
| // Input: numerator = "a", denominator = 2 | ||
| // target output: false | ||
| // Explanation: The function should handle non-numeric inputs gracefully. In this case, we choose to return false. | ||
| const invalidInputs = isProperFraction("a", 2); |
There was a problem hiding this comment.
👏 Good job making sure that 'unhappy path' is tested.
There was a problem hiding this comment.
When I run your tests, I get this result:
Assertion failed: Expected 1♠ to equal Error: Invalid card rank
Assertion failed: Expected Z♠ to equal Error: Invalid card rank
Assertion failed: Expected to equal Error: Invalid card rank
Can you take a look?
There was a problem hiding this comment.
I tried a few more 'unhappy path' tests:
- card value of true
- card value of 22
- card value of null
I was expecting ('Error: Invalid card rank').
jenny-alexander
added
Reviewed
package-lock.json
Outdated
There was a problem hiding this comment.
I think you included this file by mistake.
TzeMingHo
added
Needs Review
Learners, PR Template
Self checklist
Changelist
For the 3 exercises, I have created assert conditions and tests for each case, as well as some stretch cases.