London | 25-ITP-May | Houssam Lahlah | Sprint 1 | Coursework/sprint 1 #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments to exclude instructional lines from execution
Updated age variable to let to allow incrementing its value.
Declare variable before using in template string.
Add comments explaining slice error and fix by converting number to string.
Fix invalid variable names by renaming to start with letters instead of numbers.
Add missing comma to replaceAll so the code runs smoothly.
Add detailed comments answering questions about movie length time calculation.
Add detailed comments explaining step-by-step price formatting from pence string.
… and store the ext part of the variable
HoussamLh
added
the
Needs Review
cjyuan
added
Complete
|
Since I have reviewed and mark your work as "Complete" in the previous cohort, I will just repeat what I did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
This pull request just to syn my fork and updating my branch.
Questions
Please, let me know if there is anything else went wrong?