Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYF London | Anna Fedyna | Module-Structuring-and-Testing-Data | Week2 #69

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

annafedyna
Copy link

@annafedyna annafedyna commented Nov 1, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@annafedyna annafedyna added the Needs Review Participant to add when requesting review label Nov 1, 2024
@SallyMcGrath
Copy link
Member

Please complete your PR template and ask questions for your reviewer to help you with/ focus on. PRs are about communication.

@SallyMcGrath SallyMcGrath added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Nov 6, 2024
@annafedyna
Copy link
Author

Please complete your PR template and ask questions for your reviewer to help you with/ focus on. PRs are about communication.

Thank you for taking the time to review and for providing valuable point ! I will complete further PR templates with questions.
Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants