generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 222
Sheffield | May-2025 | WALEED-YAHYA SALIH-TAHA | Sprint-3 #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
56e3dbc
1. identified acute angel and it's function
Bluejay600 d4a0730
Identified Obtuse Angles when the angle is greater than 90 and less t…
Bluejay600 f6cd051
Identified Stright Angle s when the angle is 180 degree
Bluejay600 59a1e19
Identified stright angle when the angle is greater than 180
Bluejay600 a0004a8
1. Added 4 if conditions to the function getAngleType(angle).
Bluejay600 c7772a6
Merge branch 'Sprint3-Test-branch' of https://github.com/Bluejay600/M…
Bluejay600 eb50828
1. Added a test line to each case.
Bluejay600 b797a92
added a false return value to handle the case for improper fractions
Bluejay600 f5f36f5
1. wrote test, and make it pass, to build solution up methodically.
Bluejay600 a467519
Added 4 if conditions in the function getAngleType(angle) to build up…
Bluejay600 18a93a1
Added a return invalid angle to handle angles outside the range of 0 …
Bluejay600 3523e59
Identified and corrected the right angle when the angle is exactly 90…
Bluejay600 d6a2edf
Added assertion to the negative fraction to equal true.
Bluejay600 67a05da
Added assertion to the equal numerator and denominator, and a console…
Bluejay600 5a1570a
Stretched creating Zero Numerator check assertion.
Bluejay600 61decd0
implemented the function getCardValue(card) and added if conditions t…
Bluejay600 8e295aa
wrote the test code and added a line to pass the test.
Bluejay600 4b2e240
fixed the getCardValue function to handel card 10
Bluejay600 a1f0f58
Handled face Cards (J, Q, K) to return the value 10.
Bluejay600 ec30fb1
Added a code to handle a card with invalid rank (Z)
Bluejay600 a0595c0
Replaced the code my code in 1-key-implement and tested
Bluejay600 eda20da
Merge branch 'Sprint3-Test-branch' of https://github.com/Bluejay600/M…
Bluejay600 b0904d1
fixed acute angle test code to make the description clear.
Bluejay600 fca4456
removed the duplicated test for Acute angle
Bluejay600 71bac2d
1. removed unwanted spaces.
Bluejay600 3e96df9
1. removed the function and replaced with the function in the 1-key-i…
Bluejay600 2b1c9be
1. Replaced the comment and added angle 45 in the function.
Bluejay600 3a5be71
1. Identified Obtuse angles (90 < angle < 180 )
Bluejay600 da42c37
1. Identified reflex angles when angle is greater than 180 and less t…
Bluejay600 c9b0ff6
1. Identified Invalid angle when it's less than 0 or greater than 360.
Bluejay600 fd37f69
1. identified right angle.
Bluejay600 f242d6a
1. removed the extra space between test and the opening parenthesis:
Bluejay600 fee695d
added my completed function from key-implement.
Bluejay600 abcdfbf
identified improper fractions to case 2.
Bluejay600 af20de9
replaced the whole code with the one in card value in key-implement.
Bluejay600 7076fc0
Handled Number Cards (2-10):
Bluejay600 9ef7886
1. Handled Face Cards (J, Q, K):
Bluejay600 1b10f2d
handled invalid cards.
Bluejay600 7d4ba19
joined the two Ace functions in one.
Bluejay600 49b7c00
initialized counter to keep track of occurrences
Bluejay600 f85e00c
1. initialized a counter for the function.
Bluejay600 f3973af
Added test tarbet string
Bluejay600 3b2251a
added a test to Handle count of 0.
Bluejay600 58a71c3
Added a test to handle a negative count.
Bluejay600 1a74ee8
Implemented a function repeat that that given a target string str and…
Bluejay600 ebc99d8
Function was handling the case for 1st. I expanded to handle other n…
Bluejay600 af1e3ca
implemented case one and case 2 testing.
Bluejay600 cab246a
Merge branch 'CodeYourFuture:main' into Sprint3-Test-branch
Bluejay600 a64cee4
Played computer with the password validator
Bluejay600 a451aeb
Merge branch 'Sprint3-Test-branch' of https://github.com/Bluejay600/M…
Bluejay600 0c2e433
Merge branch 'CodeYourFuture:main' into Sprint3-Test-branch
Bluejay600 93e7226
edited on the if condition deleted the frist 3 if condition for they …
Bluejay600 3def433
Merge branch 'Sprint3-Test-branch' of https://github.com/Bluejay600/M…
Bluejay600 01b8f85
deleted unwanted function in rpeat.js file.
Bluejay600 65ebbe0
updated the test to cover all the valid integer.
Bluejay600 06f29cf
1. Replaced the wrong closing brace } at the end with proper logic.
Bluejay600 b9be3e1
added examples of previous passwords as constant list of arrays.
Bluejay600 13b9a1d
added a simecolumn after the closing of the function.
Bluejay600 162d5c6
added test conditions to the test file
Bluejay600 3a51c69
removed unwanted code or unused code.
Bluejay600 ebf4f7a
removed empty spaces.
Bluejay600 acebd47
1. fixed the code to Check for 10 before number range.
Bluejay600 c3c7466
1. Used toBe() instead of toEqual() for primitive numbers (toEqual()…
Bluejay600 3726f5d
Combined face cards returning value of 10 in one cade and removed the…
Bluejay600 fb91b98
completed the test file by adding the missing test for no occurrences
Bluejay600 fdcab1c
Updated the implementation of the function in the count.js file.
Bluejay600 7ba1ca2
removed unused code or function.
Bluejay600 efe7197
Updated the function to handel group of numbers.
Bluejay600 c56ecc4
added a group category to the frist test.
Bluejay600 0be4dc2
added the group category for the second test code.
Bluejay600 a5aa914
Edited three more test calls with group of number category test.
Bluejay600 ad76b58
Removed the rest of the unwanted test examples.
Bluejay600 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
implemented case one and case 2 testing.
- Loading branch information
commit af1e3caa522d324d2015632586030131e29ebccc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure thorough testing, we need broad scenario coverage. Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories. Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.
For example, we can prepare a test for numbers 2, 22, 132, etc. as
Can you update the tests in this script so that they can cover all valid integers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, yes I can do that.