Skip to content

Glasgow | ITP May '25 | Mirabelle Morah | Module-Structuring-and-Testing-Data | Sprint 2 #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mirabellemorah
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I added less than 5 commits to ensure things stay easily understandable. Answered questions to all mandatory sections.

Questions

Nil. Thanks!

@mirabellemorah mirabellemorah added the Needs Review Participant to add when requesting review label Jun 25, 2025
@mirabellemorah mirabellemorah marked this pull request as ready for review June 28, 2025 12:58
@YoanHlebarov YoanHlebarov added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 1, 2025
Copy link

@YoanHlebarov YoanHlebarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, you gain a good understanding of the code by reading it. This is a very important skill as it allows you to quickly understand how a piece of code is intended to work.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to see this is also that in the wrong syntax example, we are passing the argument to the function when declaring the function. Instead we pass arguments to functions when we call the function, and pass parameters to function when we declare a function. This is a small but important distinction specifically when discussing code with other developers!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know, thank you for explaining to me. I'll keep learning

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again if we go back to the above comment, this function is missing a parameter, thus passing an argument to it will simply be ignored. In other programming languages passing an argument to a function which does not have parameters will throw an exception.

@YoanHlebarov YoanHlebarov added Reviewed Volunteer to add when completing a review Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants