Skip to content

Glasgow | ITP May 25 | Mirabelle Morah | Module-Structuring-and-Testing-Data | Sprint 1 #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Glasgow | ITP May 25 | Mirabelle Morah | Module-Structuring-and-Testing-Data | Sprint 1 #597

wants to merge 5 commits into from

Conversation

mirabellemorah
Copy link

@mirabellemorah mirabellemorah commented Jun 23, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I answered all questions and showed workings for all excercises.

Questions

Nil

@mirabellemorah mirabellemorah marked this pull request as ready for review June 23, 2025 16:41
@mirabellemorah mirabellemorah added the Needs Review Participant to add when requesting review label Jun 23, 2025
@YoanHlebarov YoanHlebarov added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 1, 2025
YoanHlebarov
YoanHlebarov reviewed Jul 1, 2025
View reviewed changes
Copy link

@YoanHlebarov YoanHlebarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! You have good understanding of the code and how/why certain things can/cannot work. Keep it up!

@YoanHlebarov YoanHlebarov added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 1, 2025
@mirabellemorah
Copy link
Author

Nice work! You have good understanding of the code and how/why certain things can/cannot work. Keep it up!

Thank you

@YoanHlebarov YoanHlebarov added the Complete Volunteer to add when work is complete and review comments have been addressed label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoanHlebarov YoanHlebarov YoanHlebarov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirabellemorah @YoanHlebarov