LONDON | MAY_25 | EMILIANO URUENA | SPRINT3 #595

Emilianouz · 2025-06-23T10:39:19Z

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Sprint 3 - Module Structuring and Testing Data
COMMITS:

Key implemented MSTD Sprint-3
Mandatory Rewrite MSTD Sprint-3
Mandatory Practice / Implement MSTD Sprint-3
Stretch Investigate MSTD Sprint-3 Credit card validator

Amundeep-Dhaliwal

Hello Emiliano, hope you are well.

Thanks for submitting this work for sprint 3, please see the attached comments.

Amundeep-Dhaliwal · 2025-07-09T13:46:46Z

Sprint-3/1-key-implement/1-get-angle-type.js

+// Write the code to pass the test
+// Then, write the next test! :) Go through this process until all the cases are implemented
+
+function getAngleType(angle) {


I can see that there is an implementation of getAngleType in 2-mandatory-rewrite/1-get-angle-type.js.
Perhaps it would also be good to copy that to this file?

You're right! I just did it.

Amundeep-Dhaliwal · 2025-07-09T13:47:41Z

Sprint-3/1-key-implement/1-get-angle-type.js

+// When the angle is less than 90 degrees,
+// Then the function should return "Acute angle"
+const acute = getAngleType(45);
+assertEquals(acute, "Acute angle");


Just curious if you got this assertion statement to work?

It is working now.

Amundeep-Dhaliwal · 2025-07-09T13:52:36Z

Sprint-3/1-key-implement/2-is-proper-fraction.js

+// ====> complete with your assertion
+
+// Stretch:
+// What other scenarios could you test for?


Another test case scenario that you could cover is when the absolute numerator value is bigger than the denominator?

Example
Numerator: -5 Denominator: 3
Numerator: -7 Denominator: 2

That's a good point, I added to the next lines.

Amundeep-Dhaliwal · 2025-07-09T13:58:17Z

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

+   if (angle < 90) return "Acute angle";
+   if (angle >90 && angle < 180) return "Obtuse angle";
+   if (angle === 180) return "Straight angle";
+   if (angle > 180) return "Reflex angle";


Stretch: Is the check for angle > 90 required given the two checks on line 2 & 3?

What about when the inputted angle is 361?

Hi.. I've added the line 2 for angles upper 360 degrees.
Is requiered the check for angle between 90 and 180 degrees.

I just added in case of invalid values like 361.

90 is necesary to check values between 90 and 180.

Amundeep-Dhaliwal · 2025-07-09T13:58:41Z

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

@@ -0,0 +1,20 @@
+function getAngleType(angle) {


This function looks good

Thank you Sr.

Amundeep-Dhaliwal · 2025-07-09T14:46:49Z

Sprint-3/4-stretch-investigate/credit-card-validator.test.js

+test("(sum less than 16)", () => {expect(cardValidator(1111111111111110)).toEqual(false);});
+test("(odd final number)", () => {expect(cardValidator(6666666666666661)).toEqual(false);});
+test("valid number '9999777788880000' ", () => {expect(cardValidator(9999777788880000)).toEqual(true);});
+test("valid number '6666666666661666' ", () => {expect(cardValidator(6666666666661666)).toEqual(true);});


Glad to see that this works for the test cases outlined.

Amundeep-Dhaliwal · 2025-07-09T14:49:24Z

Sprint-3/4-stretch-investigate/credit-card-validator.js

+function cardValidator(numCard){
+let validCard = true;
+//- Number must be 16 digits, all of them must be numbers.
+validCard = validCard && (numCard.toString().length === 16);


Perhaps checks for each condition could be cleaner using if statements.

if (numCard.toString().length !== 16) { return false; }

I totally agree.

Amundeep-Dhaliwal · 2025-07-09T14:51:17Z

Sprint-3/4-stretch-investigate/credit-card-validator.js

@@ -0,0 +1,32 @@
+function cardValidator(numCard){


The type of this argument is ambiguous, from the test cases it looks as if it could be a string or number?

In this excerise, I tried to use ValidCard as a boolean general value, and reassign boolean values according to the statements. At the end it works, but I completely agree: it is more complicated and less crear.

Amundeep-Dhaliwal · 2025-07-09T15:02:15Z

Sprint-3/4-stretch-investigate/credit-card-validator.js

+            Num = numCard.toString()[i];
+        }else if ((Num !== numCard.toString()[i])){
+            sameNum = false;
+            i = numCard.toString().length;


This is one way to check if numCard has the same character throughout.

If the last character is different from the current character being looked at then terminate the loop.

Well I didn’t think that, it would be easier.

Amundeep-Dhaliwal · 2025-07-09T15:05:57Z

Sprint-3/4-stretch-investigate/credit-card-validator.js

+//- The sum of all the digits must be greater than 16.
+    let sumDigits = 0;
+    for (let i = 0 ; i < numCard.toString().length; i++){
+        sumDigits = sumDigits + numCard.toString().slice(i,i+1)*1;


What was the reason behind multiplying by 1?

Perhaps we can have a discussion about this one in person?

I was to convert the string to number without using the Number() method.

Emilianouz

The changes were done. Thank you for the feedback.

Emilianouz · 2025-07-11T17:17:10Z

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

+   if (angle < 90) return "Acute angle";
+   if (angle >90 && angle < 180) return "Obtuse angle";
+   if (angle === 180) return "Straight angle";
+   if (angle > 180) return "Reflex angle";


Hi.. I've added the line 2 for angles upper 360 degrees.
Is requiered the check for angle between 90 and 180 degrees.

Emilianouz · 2025-07-11T17:19:02Z

Sprint-3/1-key-implement/1-get-angle-type.js

+// Write the code to pass the test
+// Then, write the next test! :) Go through this process until all the cases are implemented
+
+function getAngleType(angle) {


You're right! I just did it.

Emilianouz · 2025-07-11T17:29:19Z

Sprint-3/1-key-implement/1-get-angle-type.js

+// When the angle is less than 90 degrees,
+// Then the function should return "Acute angle"
+const acute = getAngleType(45);
+assertEquals(acute, "Acute angle");


It is working now.

Emilianouz · 2025-07-11T17:36:31Z

Sprint-3/1-key-implement/2-is-proper-fraction.js

+// ====> complete with your assertion
+
+// Stretch:
+// What other scenarios could you test for?


That's a good point, I added to the next lines.

Emilianouz · 2025-07-11T17:43:11Z

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

+   if (angle < 90) return "Acute angle";
+   if (angle >90 && angle < 180) return "Obtuse angle";
+   if (angle === 180) return "Straight angle";
+   if (angle > 180) return "Reflex angle";


I just added in case of invalid values like 361.

90 is necesary to check values between 90 and 180.

Emilianouz · 2025-07-11T19:10:03Z

Sprint-3/3-mandatory-practice/implement/repeat.test.js

+    const count = -1;
+    const repeatedStr = repeat(str, count);
+    expect(repeatedStr).toEqual("Negative counts are not valid.");
+    });


Thank you Sr.

Emilianouz · 2025-07-11T19:32:42Z

Sprint-3/4-stretch-investigate/credit-card-validator.js

+//- The sum of all the digits must be greater than 16.
+    let sumDigits = 0;
+    for (let i = 0 ; i < numCard.toString().length; i++){
+        sumDigits = sumDigits + numCard.toString().slice(i,i+1)*1;


I was to convert the string to number without using the Number() method.

Emilianouz · 2025-07-11T19:36:14Z

Sprint-3/4-stretch-investigate/credit-card-validator.js

@@ -0,0 +1,32 @@
+function cardValidator(numCard){


In this excerise, I tried to use ValidCard as a boolean general value, and reassign boolean values according to the statements. At the end it works, but I completely agree: it is more complicated and less crear.

Emilianouz · 2025-07-11T19:36:36Z

Sprint-3/4-stretch-investigate/credit-card-validator.js

+function cardValidator(numCard){
+let validCard = true;
+//- Number must be 16 digits, all of them must be numbers.
+validCard = validCard && (numCard.toString().length === 16);


I totally agree.

Emilianouz · 2025-07-11T19:40:56Z

Sprint-3/4-stretch-investigate/credit-card-validator.js

+            Num = numCard.toString()[i];
+        }else if ((Num !== numCard.toString()[i])){
+            sameNum = false;
+            i = numCard.toString().length;


Well I didn’t think that, it would be easier.

Emilianouz added 4 commits June 23, 2025 11:17

1. Key implemented MSTD Sprint-3

1019587

2. Mandatory Rewrite MSTD Sprint-3

a998f9f

3. Mandatory Practice / Implement MSTD Sprint-3

e137935

4. Stretch Investigate MSTD Sprint-3 Credit card validator

ab48743

Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module labels Jun 23, 2025

This was referenced Jun 23, 2025

02 Complete Sprint 3 coursework Emilianouz/My-Coursework-Planner#62

Closed

05 📝 Code review Emilianouz/My-Coursework-Planner#65

Closed

Amundeep-Dhaliwal reviewed Jul 9, 2025

View reviewed changes

Amundeep-Dhaliwal added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 9, 2025

Emilianouz commented Jul 11, 2025

View reviewed changes

Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 11, 2025

Amundeep-Dhaliwal added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 14, 2025

illicitonion deleted the branch CodeYourFuture:to-be-deleted-coursework/sprint-3 July 21, 2025 09:46

illicitonion closed this Jul 21, 2025

Uh oh!

LONDON | MAY_25 | EMILIANO URUENA | SPRINT3 #595

LONDON | MAY_25 | EMILIANO URUENA | SPRINT3 #595

Uh oh!

Conversation

Emilianouz commented Jun 23, 2025

Changelist

Uh oh!

Amundeep-Dhaliwal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Emilianouz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!