ZA | ITP-May | Praise Magidi | Sprint-3 | Module-Structuring-and-Testing-Data #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praise88
force-pushed
the
coursework/sprint-3
branch
from
a5eef2b to
bb018c0
Compare
| @@ -43,14 +47,19 @@ assertEquals(acute, "Acute angle"); | |||
| // When the angle is greater than 90 degrees and less than 180 degrees, | |||
| // Then the function should return "Obtuse angle" | |||
| const obtuse = getAngleType(120); | |||
| assertEquals(obtuse, "Acute angle"); | |||
| // ====> write your test here, and then add a line to pass the test in the function above | ||
| const reflex = getAngleType(250); |
| @@ -9,6 +9,10 @@ | |||
|
|
|||
| function getAngleType(angle) { | |||
| if (angle === 90) return "Right angle"; | |||
| if (angle < 90) return "Acute angle"; | |||
There was a problem hiding this comment.
What if the angles are less than 0?
Waldo-Strydom
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.