ZA | ITP-May-2025 | Praise Magidi | Sprint-1 | Module-Structuring-and-Testing-Data #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praise88
changed the title
Sprint-1/1-key-exercises/3-paths.js
Outdated
| @@ -17,7 +17,9 @@ console.log(`The base part of ${filePath} is ${base}`); | |||
| // Create a variable to store the dir part of the filePath variable | |||
| // Create a variable to store the ext part of the variable | |||
|
|
|||
| const dir = ; | |||
| const ext = ; | |||
| const dir = filePath.slice(0, 49); | |||
There was a problem hiding this comment.
There is a better way to get the needed index.
| @@ -7,3 +7,9 @@ const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum; | |||
| // Try breaking down the expression and using documentation to explain what it means | |||
| // It will help to think about the order in which expressions are evaluated | |||
| // Try logging the value of num and running the program several times to build an idea of what the program is doing | |||
| console.log(num) | |||
|
|
|||
| When breaking down the expression it starts by the third brackets where maximum - minimum + 1, maximum represents a | |||
There was a problem hiding this comment.
Please use comments in your answers.
There was a problem hiding this comment.
should i edit the comments in now or this is for future reference?
| We don't want the computer to run these 2 lines - how can we solve this problem? | ||
| We can make the 2 lines comments by adding two slashes before the sentence |
There was a problem hiding this comment.
This will give an error. How do you stop the pc from running these lines.
| @@ -3,3 +3,5 @@ | |||
|
|
|||
| console.log(`I was born in ${cityOfBirth}`); | |||
| const cityOfBirth = "Bolton"; | |||
|
|
|||
| @@ -12,11 +12,17 @@ console.log(`The percentage change is ${percentageChange}`); | |||
| // Read the code and then answer the questions below | |||
|
|
|||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | |||
| line 4 and 5 | |||
|
|
||
| // c) Identify all the lines that are variable reassignment statements | ||
| line 7 and 8 |
|
|
||
| // d) Identify all the lines that are variable declarations | ||
| line 1 and 2 |
|
|
||
| // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression? | ||
| It is removing the commas from the String, making the number easier to read |
Waldo-Strydom
added
👀 Review Requirements
Praise88
added
Needs Review
Waldo-Strydom
added
👀 Review Requirements
|
I made the changes that suggested I make yesterday and added the "needs review" label, but I see I did not get the "completed" label now is there more changes I should make. |
|
Well done |
Waldo-Strydom
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.