Skip to content

Sheffield|May-2025|Sheida Shabankari|Module-Structuring-and-Testing-Data | Sprint-3 #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 37 commits into from
Closed

Sheffield|May-2025|Sheida Shabankari|Module-Structuring-and-Testing-Data | Sprint-3 #572

wants to merge 37 commits into from

Conversation

sheida-shab
Copy link

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Briefly explain your PR.
implementing functions
writing assertions and tes cases
test functions with assert function and jest
play computer and predicting and interpreting codes

Questions

Ask any questions you have for your reviewer.

sheida-shab added 22 commits June 7, 2025 15:19
@sheida-shab
Create sprint-1
40adc65 
Create sprint-1
@sheida-shab
implementing function get angel
c61fb0c
@sheida-shab
writing and passing test cases for angels
71fa8a2
@sheida-shab
implementing function for proper fraction
89c7448
@sheida-shab
writing and passing tests for proper fraction
1082edb
@sheida-shab
implementing function for card values
d9a58aa
@sheida-shab
writing and passing test cases for function card values
44ed00b
@sheida-shab
implementig and testing function with assert
e8a7465
@sheida-shab
Implement and assert function isProperFraction
50a07af
@sheida-shab
implement and assert function getCardValue
d7b198c
@sheida-shab
more assertion and error catch
ce6b980
@sheida-shab
update and improve function and test
ab10b0b
@sheida-shab
updatin and catch error
25e466c
@sheida-shab
update function
26d4e68
@sheida-shab
implement and test function countChar
b3c1079
@sheida-shab
testing and implementing getOrdinalNumber function
0cd41c0
@sheida-shab
Implement & test function repeat except error handling
d33ce93
@sheida-shab
Implement function repeat and write test cases
3084993
@sheida-shab
play computer find function
7f28d1a
@sheida-shab
write program Password Validation and test cases
8a271db
@sheida-shab
Add more test case
91de44d
@sheida-shab
add some comments
1c6712c
@sheida-shab sheida-shab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 18, 2025
cjyuan
cjyuan reviewed Jun 27, 2025
View reviewed changes
Sprint-1/1-key-exercises/coursework/sprint-1 Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the change made to this file?
It seems that you have modified this file in your main branch. That's why the change is "inherited" by subsequent branches.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the change and remove the folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is still there in your main branch. Did you push the local changes to remote (GitHub)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had removed the folder and I check it and push it again.
You can see it at "sheida-shab@41284bc"
could you please review it again?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 27, 2025
@sheida-shab sheida-shab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2025
cjyuan
cjyuan reviewed Jun 29, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed some of my comments on the following files (in my previous review):

  • Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js
  • Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
  • Sprint-3/3-mandatory-practice/implement/repeat.test.js
  • Sprint-3/4-stretch-investigate/find.js

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2025
@sheida-shab sheida-shab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 1, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 1, 2025

Changes look great! Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheida-shab @cjyuan @illicitonion