ITP JAN-2025 | ELFREDAH KEVIN-ALERECHI | MODULE STRUCTUREING AND TESTING DATA | WEEK FEBRURAY #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halilibrahimcelik
added
Needs Review
halilibrahimcelik
suggested changes
Mar 22, 2025
|
|
||
| let age = 33; // Using let to declare a variable that can be reassigned | ||
| age = age + 4; // Now I am reassigning the value of age | ||
| console.log(age); // This will print 37 to the console |
|
|
||
| capitalise("elfredah") | ||
| // =============> write your explanation here | ||
| // =============> write your new code here |
There was a problem hiding this comment.
can you write new code as well for capitalise function
| // When the angle is greater than 90 degrees and less than 180 degrees, | ||
| // Then the function should return "Obtuse angle" | ||
| const obtuse = getAngleType(120); | ||
| // ====> write your test here, and then add a line to pass the test in the function above |
There was a problem hiding this comment.
please write other condisitons inside of getangleType function as well.
| // if (!isNaN(rank)) return Number(rank); | ||
| //} | ||
|
|
||
|
|
There was a problem hiding this comment.
getCardValue function is not working as expected. Please integrate desired logic inside of the function
|
Thanks for reviewing the file. I messed up the branch files and now I am recreating a new pull request with separate sprints. Apologies for the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.