ITP-Jan 2025 | London | Maryna Romanova | Module-Structuring-and-Testing-Data | Week 6 | Sprint 3

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

@@ -1,6 +1,13 @@
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
-    else return false;
-    // add your completed function from key-implement here
-}
+    if (denominator === 0) return false; 
+    return Math.abs(numerator) < Math.abs(denominator);
+  }
+// function isProperFraction(numerator, denominator) {
+//     if (numerator < denominator) return true;
+//     else return false;
+//     // add your completed function from key-implement here
+// }
+
+
+
 module.exports = isProperFraction;

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js

@@ -4,8 +4,8 @@ test("should return true for a proper fraction", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
   expect(isProperFraction(5, 2)).toEqual(false);  
   expect(isProperFraction(5, -2)).toEqual(false);  
-  expect(isProperFraction(-5, 2)).toEqual(true);    
-  expect(isProperFraction(-5, -2)).toEqual(true);  
+  expect(isProperFraction(-5, 2)).toEqual(false);    
+  expect(isProperFraction(-5, -2)).toEqual(false);  
 }); 
 
 

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

@@ -4,11 +4,10 @@
     function getCardValue(card) {
         const rank = card.slice(0, -1);
           if (rank === "A") return 11;
-          if (rank === "J" || rank === "Q" || rank === "K" || rank === "10") return 10;
-          if (rank >= "2" && rank <= "9") return parseInt(rank);
-          throw new Error("Invalid");
+          if (["J", "Q", "K", "10"].includes(rank)) return 10;
+          if (/^[2-9]$/.test(rank)) return Number(rank);
+         throw new Error("Invalid")
         }
 
 
-
 module.exports = getCardValue;

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

@@ -24,6 +24,14 @@ expect(handleAce).toEqual(11);
 });
 
 // // Case 5: Handle Invalid Cards:
+// test("Handle Ace (A)", () => {
+//     const handleAce = getCardValue("29♠");
+//     expect(handleAce).toEqual("Invalid");
+//     });
+
+//Case 5: Handle Invalid Cards:
 test("Handle Invalid Cards", () => {
-    expect(() => getCardValue("Z♥")).toThrow("Invalid");
-  });
+   expect(() => getCardValue("Z♥")).toThrow("Invalid");
+   expect(() => getCardValue("29♠")).toThrow("Invalid");
+   expect(() => getCardValue("2.1♠")).toThrow("Invalid");
+ });

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

@@ -10,7 +10,7 @@ const getOrdinalNumber = require("./get-ordinal-number");
 
 
 
-test("should return '3rd' for 3 and more", () => {
+test("should return all mentioned test bellow", () => {
     expect(getOrdinalNumber(3)).toEqual("3rd");
     expect(getOrdinalNumber(3)).toEqual("3rd");  
     expect(getOrdinalNumber(23)).toEqual("23rd");