London_ITP_Jan2025| Aung_Ye_Kyaw |Module-Structuring-Testing-Data |Coursework/sprint 1 #319

sarawone · 2025-02-21T20:22:19Z

I have followed the points as per read me file and put the answer in each file.
Please kindly review and let me know the requirements.
Thanks for your time & support ..

illicitonion

You have both sprint 1 and sprint 2's work in here - please move sprint 2's to another pull request and get it reviewed separately, I have only reviewed sprint 1's here.

In general things are looking decent here, but I'd encourage you to think about the meaning in the problem domain of the code, not just in JavaScript. If we're dealing with time, or money, what do values/operations represent thinking about time/money, not just strings/variables.

Sprint-1/1-key-exercises/2-initials.js

Sprint-1/1-key-exercises/3-paths.js

illicitonion · 2025-03-05T18:22:28Z

Sprint-1/1-key-exercises/3-paths.js

-const ext = ;
+const dir = filePath.slice(0,lastSlashIndex+1);
+console.log (`The dir part of the file path ${dir}`);
+const ext = filePath.slice(-3);


This works, but it is not very general. If the filePath variable contained a file named hello.jpeg, I don't think it would return the correct result. Can you think how to solve this which would work regardless of the number of characters in the extension?

Thanks for the feedback .
I fixed the filePath for general purposes. Please check and provide feedback.

Looks great, much more general - thanks!

What do you think would happen if the filename didn't contain any .s? What do you think should happen in that case?

It will return the whole file part .
LastIndexof (".") will return -1 if there are no "." in the file path.
So the slice method will cut the string from the start .

Do you think this is a good answer to the question "What is the extension of this file"? Or is there some better answer we could give?

It will return the whole file path . I think it should raise an error message ("incorrect file format ").

illicitonion · 2025-03-05T20:58:02Z

Sprint-1/1-key-exercises/4-random.js

 const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum;

+
+const step1 = Math.random();  // get random number >=0 & <1


I think this is a good explanation, breaking it down into steps is really useful, but can you also talk about what the whole thing does, as well as just the separate steps?

As a whole thing this program is for testing Operator precedence , in order to know which operation performs fast . I answered as per I understand :)
Please guide me if I am in the wrong way .. Thank you .

Precedence is one of the things being tested here, but general code understanding is too :) Can you try to also describe this code in terms of the problem?

e.g. in the initials exercise you could describe in problem terms we're "Making a string of the first letter of each name" (whereas in programming terms we'd maybe say "We're making variables storing the first character of each name, and then concatenating them together into one variable")

We are making a variable storing the result of round down to nearest largest number of the random numbers multiplied by the result of maximum number subtract minimum , after that adding by 1 and then adding with minimum value.

Sprint-1/2-mandatory-errors/3.js

Sprint-1/3-mandatory-interpret/2-time-format.js

illicitonion · 2025-03-05T21:03:49Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

 // 1. const penceString = "399p": initialises a string variable with the value "399p"
+// 2. const penceStringWithoutTrailingP = penceString.substring(0,penceString.length - 1) : removing p by using substring method.
+// 3.const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"); : adding 0 to the start from the left side in case of penstring have 2 numbers only 
+// 4. const pounds = paddedPenceNumberString.substring(0,paddedPenceNumberString.length - 2); : getting the first letter from the string 


The first letter? What's in the string? Why would we be getting the first letter from it?

Getting the first character from the string to get the pound value from the given string penny .

illicitonion · 2025-03-05T21:04:14Z

Sprint-1/4-stretch-explore/chrome.md

+  pop up dialog box with text box to accept user input 
+
 What is the return value of `prompt`?
+ string is the return value of prompt


What is returned if the user presses cancel?

null value if user press cancel or enter without typing any value in text box.

illicitonion · 2025-03-05T21:04:27Z

Sprint-1/4-stretch-explore/objects.md

 Answer the following questions:

 What does `console` store?
+store data for a while 


What do you mean by "a while"? Where does it store data?

It stores data temporarily on the browser's memory when it is open and disappear when refreshing the browser .

sarawone · 2025-03-07T22:22:44Z

You have both sprint 1 and sprint 2's work in here - please move sprint 2's to another pull request and get it reviewed separately, I have only reviewed sprint 1's here.

In general things are looking decent here, but I'd encourage you to think about the meaning in the problem domain of the code, not just in JavaScript. If we're dealing with time, or money, what do values/operations represent thinking about time/money, not just strings/variables.

Thanks for the comments.
I already did another PR for sprint 2 .

I did not get your point in the second part. Could you please explain to me again for those ? Thank you so much .

illicitonion · 2025-03-11T10:22:34Z

You have both sprint 1 and sprint 2's work in here - please move sprint 2's to another pull request and get it reviewed separately, I have only reviewed sprint 1's here.
In general things are looking decent here, but I'd encourage you to think about the meaning in the problem domain of the code, not just in JavaScript. If we're dealing with time, or money, what do values/operations represent thinking about time/money, not just strings/variables.

Thanks for the comments.
I already did another PR for sprint 2 .

I did not get your point in the second part. Could you please explain to me again for those ? Thank you so much .

Let's take a look at an example from 3-to-pounds:

You wrote: "removing p by using substring method."

This is correct. But what does that mean? It gives us a string containing the number of pence, which we can then convert to a number if we want.

That meaning - that removing the p gives us the number of pence, is really useful to think about. Thinking not just about what we're doing in terms of code, but in terms of the problem. The language of javascript is all about strings and numbers. The language of this problem is about numbers of pence and pounds.

Similarly: "get the last two letter and add zero in case if there is only one letter."

Again, this is true, but in problem terms we're getting the number of pence after taking away all of the whole pounds.

In the future, try to answer questions in both terms - what are we doing in code, and what are we doing in the problem :)

illicitonion

Some good improvements, well done!

illicitonion · 2025-03-11T10:17:33Z

Sprint-1/1-key-exercises/2-initials.js

-let initials = ``;
+// declaring variables for each name and take out fist character
+
+let fname_initials = `${firstName.charAt(0)}`;


In JavaScript we tend to use camelCase not snake_case for variable names, so this would be fnameInitials rather than fname_initials. This isn't a big deal - the code works either way, but it's a convention we tend to stick to.

Thanks for the advice .
I have changed all the variable names as camelCase.

illicitonion · 2025-03-11T10:17:52Z

Sprint-1/1-key-exercises/2-initials.js

-let initials = ``;
+// declaring variables for each name and take out fist character
+
+let fname_initials = `${firstName.charAt(0)}`;


Because charAt returns a string, we don't need to interpolate this into a string as well

Suggested change

let fname_initials = `${firstName.charAt(0)}`;

let fname_initials = firstName.charAt(0);

Remove string interpolate.

illicitonion · 2025-03-11T10:18:20Z

Sprint-1/1-key-exercises/2-initials.js

-let initials = ``;
+// declaring variables for each name and take out fist character
+
+let fname_initials = `${firstName.charAt(0)}`;


This string will contain exactly one character, so initial is probably a better than than initials, which suggests it contains more than one :)

noted and changed as per suggestion . Thank you.

Sprint-1/1-key-exercises/2-initials.js

Sprint-1/1-key-exercises/3-paths.js

illicitonion · 2025-03-11T10:19:18Z

Sprint-1/1-key-exercises/3-paths.js

-const ext = ;
+const dir = filePath.slice(0,lastSlashIndex+1);
+console.log (`The dir part of the file path ${dir}`);
+const ext = filePath.slice(-3);


Looks great, much more general - thanks!

What do you think would happen if the filename didn't contain any .s? What do you think should happen in that case?

illicitonion

Good improvements!

Sprint-1/1-key-exercises/2-initials.js

illicitonion · 2025-03-13T09:57:46Z

Sprint-1/1-key-exercises/4-random.js

 const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum;

+
+const step1 = Math.random();  // get random number >=0 & <1


Precedence is one of the things being tested here, but general code understanding is too :) Can you try to also describe this code in terms of the problem?

e.g. in the initials exercise you could describe in problem terms we're "Making a string of the first letter of each name" (whereas in programming terms we'd maybe say "We're making variables storing the first character of each name, and then concatenating them together into one variable")

Sprint-1/3-mandatory-interpret/2-time-format.js

illicitonion · 2025-03-13T09:58:58Z

Sprint-1/1-key-exercises/3-paths.js

-const ext = ;
+const dir = filePath.slice(0,lastSlashIndex+1);
+console.log (`The dir part of the file path ${dir}`);
+const ext = filePath.slice(-3);


Do you think this is a good answer to the question "What is the extension of this file"? Or is there some better answer we could give?

Sprint-1/2-mandatory-errors/3.js

Sprint-1/3-mandatory-interpret/2-time-format.js

illicitonion · 2025-03-13T10:01:29Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+        // 5
 // b) How many function calls are there?
-
+        //no function calls


There are also functions that the user didn't define, but that already exist in the language.

A function call generally looks like a pair of ()s after a name (possibly with some values between the ()s).

Do you see any places in this code where there's a name, and then a (, then maybe some values, then a )?

This would still be a function call, even if the user didn't define the function themselves.

Sprint-1/3-mandatory-interpret/2-time-format.js

sarawone · 2025-03-13T17:50:44Z

Checked the feedback and updated/modified the requirements . Ready for review and provide feedback . Thank you

sarawone · 2025-03-18T00:20:04Z

Could I change the status to Complete .? :)

illicitonion · 2025-03-18T14:49:46Z

Sprint-2/5-stretch-extend/format-time.js

 }

-const currentOutput = formatAs12HourClock("08:00");
+const currentOutput = formatAs12HourClock("08:30");


You've correctly identified an issue here, and written a good test for it, but the test is currently failing. Can you fix the code so the test passes?

This change need to submit on Sprint-2 ..Shall I update on spring-2 ?

Aah good call, sorry I didn't realise there were still two sprints of work in here (this is one of the reasons it can be useful to remove the incorrectly added work from one branch when you put it in another :))

Thank for your guidance and feedback .I will update to Sprint-2 by fixing the code . :)
Thank you so much .

illicitonion · 2025-03-18T14:50:16Z

Nearly! I left two last comments! Thanks for putting in the work to see this through!

sarawone added 7 commits February 20, 2025 15:36

put answer in comment

7ce428b

getting dir and ext part from filepath

6442b27

breaking down the expression in step by step

b31a592

fixing error

8f67390

checking error and write the reason of the error.

abbe390

interpret and adding answers

03caef7

adding answers

c8d6e99

sarawone self-assigned this Feb 21, 2025

sarawone added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 21, 2025

sarawone added 5 commits February 21, 2025 20:30

finding error and explain

da12dc5

read and answer the questions

713cbf9

adding answers

2b9bd4e

adding answer

73fec8d

adding code

b352caf

sarawone mentioned this pull request Feb 24, 2025

03 Complete Sprint 1 Coursework sarawone/My-Coursework-Planner#45

Open

illicitonion added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 5, 2025

illicitonion reviewed Mar 5, 2025

View reviewed changes

illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 5, 2025

sarawone added 3 commits March 7, 2025 22:31

correct interpolated string literal

327e641

removing / from dir

ee1a81d

fixing for ext part

0ae808c

illicitonion reviewed Mar 11, 2025

View reviewed changes

sarawone added 4 commits March 13, 2025 00:11

format code as per suggestion

5df1edb

adding second method

fd06577

correct error for function call

129e936

updating the comments in the code

bb4ca32

illicitonion reviewed Mar 13, 2025

View reviewed changes

sarawone added 2 commits March 13, 2025 16:59

correct the function call comment

6e92b38

updating comment

da1d543

sarawone added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 13, 2025

chaning variable name on console

2e70c80

illicitonion reviewed Mar 18, 2025

View reviewed changes

illicitonion removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 18, 2025

declaring a variable for first character of each name

a2ee725

illicitonion added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Mar 18, 2025

illicitonion closed this Sep 1, 2025

		const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum;


		const step1 = Math.random(); // get random number >=0 & <1

	let fname_initials = `${firstName.charAt(0)}`;
	let fname_initials = firstName.charAt(0);

Uh oh!

London_ITP_Jan2025| Aung_Ye_Kyaw |Module-Structuring-Testing-Data |Coursework/sprint 1 #319

London_ITP_Jan2025| Aung_Ye_Kyaw |Module-Structuring-Testing-Data |Coursework/sprint 1 #319

Uh oh!

Conversation

sarawone commented Feb 21, 2025

Uh oh!

illicitonion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sarawone commented Mar 7, 2025

Uh oh!

illicitonion commented Mar 11, 2025

Uh oh!

illicitonion left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

illicitonion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!