JAN 25 London | MIKIYAS GEBREMICHAEL | STRUCTURING AND TESTING DATA | WEEK 1 #270
Conversation
…: I am sorry for my english it might be a little confusing.
|
For the Mentor |
Mikiyas-STP
added
📅 Sprint 1
Sprint-1/1-key-exercises/3-paths.js
Outdated
|
|
||
| const dir = ; | ||
| const ext = ; | ||
| const dire = filePath.slice(1, lastSlashIndex); |
There was a problem hiding this comment.
Intended variable name is written incorrectly.
Look under the 'dir' column and see all the characters that fall within it, as the range of this slice is insufficient.
There was a problem hiding this comment.
i will see this with a mentor on saturday. OR please let me know if you have free time for a quick call to resolve this issue since i didn't understand my mistake here. Or if you cant please Comment out for [Sprint-1/1-key-exercises/3-paths.js]AND [Sprint-1/3-mandatory-interpret/2-time-format.js] so that i will close this PR , THANK YOU CE-O
There was a problem hiding this comment.
i commited my work for the corrections as well
Sprint-1/2-mandatory-errors/3.js
Outdated
| @@ -1,9 +1,16 @@ | |||
| const cardNumber = 4533787178994213; | |||
| const last4Digits = cardNumber.slice(-4); | |||
| const last4Digits = cardNumber.toString().slice(-4); | |||
There was a problem hiding this comment.
Good work, but I would advise that you make last4Digits the same data type as cardNumber
| @@ -1,2 +1,5 @@ | |||
| const 12HourClockTime = "20:53"; | |||
| const 24hourClockTime = "08:53"; | |||
| const 24hourClockTime = "08:53"; | |||
There was a problem hiding this comment.
Please fix the error.
There is another error present here. Please carefully compare the variable names to their respective values and see if you notice anything wrong.
|
|
||
| // line 1,2,7 and 8 are variable declarations. | ||
| // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression? | ||
| //it is replacing the characters in the string specified in the bracket to make them numbers. |
There was a problem hiding this comment.
Could you please be just a little bit more specific? Not too in-depth, but be more specific about the details of the function.
| // 6 | ||
| // b) How many function calls are there? | ||
|
|
||
| // 0 |
There was a problem hiding this comment.
That is incorrect. Look over the code more carefully.
There was a problem hiding this comment.
i didn’t see any function call even if i try to . for b it is 0. did i miss your question?
|
|
||
| // it represent the duration of the movie in hr min and sec , "duration" is better variable naming | ||
| // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer | ||
| //i have checked it using many numbers but it doesnt work for float numbers and negative numbers (conceptually since their is no negative duration) |
There was a problem hiding this comment.
The question is only asking about whole numbers, as movieLength is not supposed to be a float variable or have a negative value.
Mikiyas-STP
removed
the
Needs Review
halilibrahimcelik
added
the
Reviewed
Mikiyas-STP
added
the
Complete
|
All tasks done. |
3 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.