Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

London07/Loveth-Okafor/Module-Structuring-and-Testing-Data/Sprint 2(key errors)-/WEEK2 #248

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

London07/Loveth-Okafor/Module-Structuring-and-Testing-Data/Sprint 2(key errors)-/WEEK2 #248

wants to merge 23 commits into from

Conversation

loveth900
Copy link

@loveth900 loveth900 commented Jan 31, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@loveth900
the variable is being explain directory
2cc775a
@loveth900
The + operator concatenates the first characters to form the string "…
1a80631 
…CKJ"
@loveth900
the num was input proper
64d70b9
@loveth900
i have converted them into comments
24ae22c
@loveth900
i allow reassignment of the age
0eebb5d
@loveth900
the correct output is bolton
556e0cb
@loveth900
the code did not work because the .slice can only be used on a string…
d1aed89 
… not a number
@loveth900
variable cannot start with a number.
7f2ed9a
@loveth900
extracts and displays the base, dir, and ext parts of the file path.
2aae128
@loveth900
A variable reassignment occurs when we change the value of an already…
48ac3d7 
… declared variable
@loveth900
variable declarations are allowed
3e66c4e
@loveth900
This ensures the program correctly converts any valid input into poun…
f98afd4 
…ds and pence format.
@loveth900
str is already defined as a function parameter.
10ca884
@loveth900
The function parameter decimalNumber is redeclared
1ad2256
@loveth900
The function declaration should define a generic parameter
ff6c67a
@loveth900
the function returns the correct value
a0dea50
@loveth900
the function correctly returns the sum
46b994c
@loveth900
the function was decleared
3f3bd9f
@loveth900
yhe value of the BMI was returned
8b73659
@loveth900
the upper case was replace
6f7fd2e
@loveth900
This function is now reusable for any weight input
c1909c6
@loveth900
formatTimeDisplay
fa44d50
@loveth900
various inputs were declared
417bdc3
@loveth900 loveth900 added the Needs Review Participant to add when requesting review label Jan 31, 2025
@loveth900
Copy link
Author

dear mentors kindly help me review my work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review Participant to add when requesting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loveth900