CYF-ITP-South Africa | Rashaad Ebrahim | Module-Structuring-and-Testing-Data | Week 3

[Rashaad-Ebrahim]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Exercises completed and all necessary tests created.

Questions

On the is-prime.test.js, I created fours tests. Two related to testing prime numbers, and two related to testing non- prime numbers.

Of the two tests, the first test is to check if the function was working correctly. What I was trying to, was run the first test and if it failed, then only would the second test be run. The second test would then indicate where the error is coming from.

Is this even possible with Jest? I tried many different thing but to no avail. Any input?

What I wanted to to

[cjyuan]

Each describe in Jest is carried out concurrently. As a result, it is difficult to ensure tests in two different describe's are performed in a particular order. Even within the same describe, it is not easy to specify "perform test B if test A fails".

I am not sure why you need short/long test in your 'is-prime.test.js`. If a short test fails, what's the reason to run the longer version?

Here is one possible way to perform test B if test A fails:

  test("Perform test B if test A failed", () => {
    try {
      // Test A
      expect(true).toBe(false);  // Simulate a failed test
    } catch (error) {
      // Test B
      expect(...).toBe(...);

      // Nested "test" is not allowed; we cannot call test() inside a test().
      // test("Test B", () => { expect(...).toBe(...); });
    }
  });

[cjyuan]

@shreefAhmedM I noticed that you have added the "Reviewed" label in this PR, but I cannot see any of your comment. Have you reviewed Rashaad code and gave feedback to Rashaad accordingly?

[Rashaad-Ebrahim]

Thanks @cjyuan, I'll give that a try.

I know this isn't a great scenario to run a "short" and "long" test, the idea just came to me and I wanted to know if its possible in the event I ever want to use it in another application.

[cjyuan]

@Rashaad-Ebrahim Does this PR still need any review?

[shreefAhmedM]

@shreefAhmedM I noticed that you have added the "Reviewed" label in this PR, but I cannot see any of your comment. Have you reviewed Rashaad code and gave feedback to Rashaad accordingly?
Im very sorry about that its happened by mistake I was trying to implement some changes based on your review

[Rashaad-Ebrahim]

@cjyuan I do still ned my PR reviewed.

[cjyuan]

Code is well written and tests are very comprehensive!
I left some comments and suggestions.

The function in get-card-value.js can miss some invalid cases.

[Rashaad-Ebrahim]

Suggested changes have been implemented.

[cjyuan]

Code looks good. Just few more suggestions.

[Rashaad-Ebrahim]

Changes implemented.

[cjyuan]

You can mark your PR as "completed" any time you think you have made all the changes. You don't have to request for review for every change.

[illicitonion]

Closing in favour of #480