CYF-ITP-South Africa | Serna Malala| Module-Structuring-and-Testing-Data | Week 3

[sernamalala]

Learners, PR Template

Self checklist

• [y] I have committed my files one by one, on purpose, and for a reason
• [y] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• [y] I have tested my changes
• [y] My changes follow the style guide
• [y] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

I have completed all the exercises, I have implemented functions as required according to the conditions given and I have also created test files for these functions by using Jest.

Questions

Regarding commenting in the test function, how descriptive should they be?

Ask any questions you have for your reviewer.

[cjyuan]

I left comments and suggestions in the code.

[cjyuan]

Regarding your question, "Regarding commenting in the test function, how descriptive should they be?"

Write it in such a way that

• You think another programmer (i.e., PR reviewer) would understand
• You would still understand what you wrote after revisiting your code 6 months from now.

I personally prefer concise description. Complete sentence is not needed.

[sernamalala]

Hi @cjyuan I've looked at your review comments and I've adjusted those that I could. I left some questions for the comments I found a bit more difficult to understand.

[KudahShambare]

Instead of using multiple if/else consider using switch statements

https://www.w3schools.com/js/js_switch.asp

[sernamalala]

Hi @KudahShambare I am only seeing your review now. I already responded to CJ's review

[KudahShambare]

How are you handling the equal denominator and equal numerator scenario?

[KudahShambare]

Is it passing all the tests?

[KudahShambare]

when arranging your code in if statements, consider following either an ascending/descending (depending with the situation) pattern. In this case you are starting with 0, then negative numbers then finally positive numbers. This order of your statements affects how the code is executed. For example if num is -7, firstly its going to compare if its equal to 0 and then continues to check if it's less than 0 (Here it will throw an error. If we swap the conditions it will just throw an error without even running the equality test -- saving time)

[KudahShambare]

https://stackoverflow.com/questions/62150130/algorithm-of-checking-if-the-number-is-prime

Refer to the discussion in the link above. For large numbers, your implementation of the algorithm will be very slow.