Fixed Password function & and Tests

Sprint-3/revise/implement/password-validator.js

@@ -17,7 +17,7 @@ You must breakdown this problem in order to solve it. Find one test case
 first and get that working
 */
 
-function isNumberValid(input) {
+/*function isNumberValid(input) {
   if (typeof input === "number" && input >= 10000) {
     return true; // Have at least 5 characters.
   }
@@ -37,17 +37,51 @@ function isNumberValid(input) {
     }
   }
   return false; // If none of the above checks passed, the input is not valid
-}
+}*/
 
-// Examples of how the function works:
+/* Examples of how the function works:
 console.log(isNumberValid(15000)); // true (number >= 10000)
 console.log(isNumberValid("A")); // true (single uppercase letter)
 console.log(isNumberValid("z")); // true (single lowercase letter)
 console.log(isNumberValid("5")); // true (single digit)
 console.log(isNumberValid("*")); // true (special character)
 console.log(isNumberValid("Hello")); // false (not valid)
 console.log(isNumberValid(5000)); // false (number < 10000)
-console.log(isNumberValid("!!")); // false (more than one character)
+console.log(isNumberValid("!!")); // false (more than one character)*/
 
+function isValidPassword(password, previousPasswords) {
+  // 1. Check password length
+  if (password.length < 5) {
+    return false; 
+  }
+
+  // 2. Check for uppercase letter
+  if (!/[A-Z]/.test(password)) { 
+    return false; 
+  }
+
+  // 3. Check for lowercase letter
+  if (!/[a-z]/.test(password)) { 
+    return false; 
+  }
+
+  // 4. Check for number
+  if (!/\d/.test(password)) { 
+    return false; 
+  }
+
+  // 5. Check for special character
+  if (!/[!#$%&*.]/.test(password)) { 
+    return false; 
+  }
+
+  // 6. Check for previous passwords
+  if (previousPasswords.includes(password)) {
+    return false;
+  }
+
+  // All conditions met
+  return true;
 
-module.exports = isNumberValid;
+};
+module.exports = isValidPassword;

Sprint-3/revise/implement/password-validator.test.js

@@ -1,7 +1,7 @@
 
-const isNumberValid = require("./password-validator");
 
-test("Should validate a number with at least 5 characters", () => {
+
+/*test("Should validate a number with at least 5 characters", () => {
   const input = 112206;
   const output = isNumberValid(input);
   expect(output).toBe(true); // A valid number
@@ -23,8 +23,55 @@ test("Should invalidate a special character not in the list", () => {
   const input = "@";
   const output = isNumberValid(input);
   expect(output).toBe(false); // Invalid because "@" is not in the list of special characters
-});
+});*/
+
+
+// passwordValidator.test.js
+const isValidPassword = require('./password-validator');
+
+describe('isValidPassword', () => {
+  it('should return true for a valid password', () => {
+    const password = 'MyStrongPass123!';
+    const previousPasswords = ["oldPass1", "oldPass2"];
+    expect(isValidPassword(password, previousPasswords)).toBe(true);
+  });
+
+  it('should return false for a password shorter than 5 characters', () => {
+    const password = 'Pass';
+    const previousPasswords = [];
+    expect(isValidPassword(password, previousPasswords)).toBe(false);
+  });
 
+  it('should return false if no uppercase letter is present', () => {
+    const password = 'mystrongpass123!';
+    const previousPasswords = [];
+    expect(isValidPassword(password, previousPasswords)).toBe(false);
+  });
+
+  it('should return false if no lowercase letter is present', () => {
+    const password = 'MYSTRONGPASS123!';
+    const previousPasswords = [];
+    expect(isValidPassword(password, previousPasswords)).toBe(false);
+  });
+
+  it('should return false if no digit is present', () => {
+    const password = 'MyStrongPass!';
+    const previousPasswords = [];
+    expect(isValidPassword(password, previousPasswords)).toBe(false);
+  });
+
+  it('should return false if no special character is present', () => {
+    const password = 'MyStrongPass123';
+    const previousPasswords = [];
+    expect(isValidPassword(password, previousPasswords)).toBe(false);
+  });
+
+  it('should return false if the password is in the previousPasswords array', () => {
+    const password = "oldPass1";
+    const previousPasswords = ["oldPass1", "oldPass2"];
+    expect(isValidPassword(password, previousPasswords)).toBe(false);
+  });
+});