Skip to content

Conversation

Luke-Manyamazi
Copy link

@Luke-Manyamazi Luke-Manyamazi commented Nov 20, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.
This PR is fro the new branch that I created to separate Sprint 1 exercises from Sprint 2 exercises

Questions

Ask any questions you have for your reviewer.

  • Did I manage to separate the files as per your expectations?

@Luke-Manyamazi Luke-Manyamazi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 20, 2024
@Dave-Vermeulen
Copy link

Peer Reviewed:
@Luke-Manyamazi code is clean with a fair amount of test cases where applicable written in a format that is understandable and follows the best practices which aligns with automated testing using jest. Each file in Sprint 2 has been carefully reviewed to check the changes. The code written has no identifiable faults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants