Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LON | Amirhossein Aminian | Module-structuring-and-testing-data | sprint3 #142

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

LON | Amirhossein Aminian | Module-structuring-and-testing-data | sprint3 #142

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
a9422f3
get-angle
AmirhosseinAminian Nov 10, 2024
fcbc6ce
get-card-value
AmirhosseinAminian Nov 11, 2024
c4029b3
fraction
AmirhosseinAminian Nov 12, 2024
73fb2ad
valid-triangle
AmirhosseinAminian Nov 12, 2024
5f53537
rotate-chart
AmirhosseinAminian Nov 13, 2024
22b26ab
credit_card_number
AmirhosseinAminian Nov 13, 2024
d0f894d
count_char
AmirhosseinAminian Nov 14, 2024
a04f883
ordinal_number-test
AmirhosseinAminian Nov 14, 2024
37c799f
Fixing feedback
AmirhosseinAminian Nov 14, 2024
3a19cbb
is_prime
AmirhosseinAminian Nov 14, 2024
9617648
feedback
AmirhosseinAminian Nov 14, 2024
048a134
password_validation
AmirhosseinAminian Nov 14, 2024
7f4fdbe
repeat_test
AmirhosseinAminian Nov 14, 2024
0696a5a
find.js
AmirhosseinAminian Nov 14, 2024
bf0c3b5
find.js
AmirhosseinAminian Nov 14, 2024
bb8e1c8
Merge branch 'main' into amiraminia/sprint3
SallyMcGrath Nov 21, 2024
2ce2bba
java to javascript
AmirhosseinAminian Nov 21, 2024
004e0ec
Merge branch 'amiraminia/sprint3' of https://github.com/Amir200524/Mo…
AmirhosseinAminian Nov 21, 2024
6d213de
java to javascript
AmirhosseinAminian Nov 21, 2024
b402751
java to javascript
AmirhosseinAminian Nov 21, 2024
e964339
converting to JavaScript
AmirhosseinAminian Nov 21, 2024
c970c82
more test case
AmirhosseinAminian Nov 21, 2024
fd5fd05
jest test
AmirhosseinAminian Nov 23, 2024
e480c7d
deleted example file
AmirhosseinAminian Nov 23, 2024
9423d02
generating test.js
AmirhosseinAminian Nov 23, 2024
b5dd0e1
fixing feedback
AmirhosseinAminian Nov 23, 2024
2160580
fixing password.test
AmirhosseinAminian Nov 23, 2024
6fbaaa4
generating count.test
AmirhosseinAminian Nov 23, 2024
e8ae613
generating get-ordinalnumber.test
AmirhosseinAminian Nov 23, 2024
e54439f
generating password-validator.test
AmirhosseinAminian Nov 23, 2024
e112659
generating repeat.test
AmirhosseinAminian Nov 23, 2024
9507417
fixing code
AmirhosseinAminian Nov 23, 2024
acf58fb
fixing repeat.test & repeat.js
AmirhosseinAminian Nov 23, 2024
67e8477
test of number of digits is exactly 16
AmirhosseinAminian Nov 30, 2024
b71f5a4
generate ifs for special case and skip even numbers
AmirhosseinAminian Nov 30, 2024
c88ad5f
export previousPasswords
AmirhosseinAminian Nov 30, 2024
b547b6c
Handles the special case & Eliminates even numbers
AmirhosseinAminian Nov 30, 2024
4018a61
Shift Normalization
AmirhosseinAminian Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
export previousPasswords
  • Loading branch information
@AmirhosseinAminian
AmirhosseinAminian committed Nov 30, 2024
commit c88ad5fb64f7f2ac8e601ba8e00afd37f4cee863
5 changes: 4 additions & 1 deletion Sprint-3/revise/implement/password-validator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,7 @@ function isValidPassword(password, previousPasswords) {

// Sample list of previous passwords
const previousPasswords = ["password123", "abc123", "welcome1"];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You can also export previousPasswords.
  2. The passwords in previousPasswords are all invalid passwords.

module.exports = isValidPassword;

// Export both the function and the previousPasswords array
module.exports = isValidPassword;