Manchester | 25-ITP-Sep | khalid bih | Sprint 2 | Form controls #829
Manchester | 25-ITP-Sep | khalid bih | Sprint 2 | Form controls #829khalidbih wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
khalidbih
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint2) doesn't match expected format (example: 'Sprint 2', without quotes) |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint2) doesn't match expected format (example: 'Sprint 2', without quotes) |
khalidbih
changed the title
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
khalidbih
changed the title
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
khalidbih
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
khalidbih
added
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
2 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
khalidbih
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
khalidbih
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
khalidbih
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
khalidbih
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
khalidbih
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
CameronDowner
left a comment
CameronDowner
left a comment
There was a problem hiding this comment.
Looking good! All hard requirements are met, just a few things to clean up 🙂
| <fieldset> | ||
| <legend>Customer Details</legend> | ||
|
|
||
| <label for="customer-name">Name</label> |
There was a problem hiding this comment.
Is this label referencing the input properly?
There was a problem hiding this comment.
It wasn't because it didn't match, now I fixed it
| <option value="xxl">XXL</option> | ||
| </select> | ||
| </fieldset> | ||
| <button type="submit" style="min-width:48px; min-height:48px;">Order</button> |
There was a problem hiding this comment.
Is there another way to apply styles to these elements? What might be the differences to other approaches to applying styles?
There was a problem hiding this comment.
@khalidbih Could you answer this question?
I'll mark as complete as you have completed the coursework, but would be good to test your understanding here 🙂
| <legend>Customer Details</legend> | ||
|
|
||
| <label for="customer-name">Name</label> | ||
| <input type="text" name="name" id="customerName" minlength="2" placeholder="customer-name" required style="min-width:48px; min-height:48px;">> |
There was a problem hiding this comment.
It looks there are duplicate > characters that are showing on the page
There was a problem hiding this comment.
Yes, deleted the extra > character
| <input type="text" name="name" id="customerName" minlength="2" placeholder="customer-name" required style="min-width:48px; min-height:48px;">> | ||
|
|
||
| <label for="customer-email">Email</label> | ||
| <input type="email" name="email" id="customerEmail" placeholder="customer-email" required style="min-width:48px; min-height:48px;">> |
There was a problem hiding this comment.
The placeholder is visible to users of the website - is there a more human-readable placeholder we could use for our inputs?
There was a problem hiding this comment.
I used Enter your full name, and Enter your full email. I think this is more human-readable.
| @@ -0,0 +1,46 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Could you check this HTML with a HTML validator and solve any issues?
You can copy & paste your HTML under Validate by direct input
There was a problem hiding this comment.
I've used the HTML validator, and it shows no more errors or warnings
There was a problem hiding this comment.
Perfect score on the validator 🙌
CameronDowner
added
Reviewed
khalidbih
added
Needs Review
CameronDowner
added
Complete
|
Really great commit messages by the way - I can clearly see the changes you've made in this PR 👍 |
3 participants
Self checklist:
Changelist
Added form-controls.html with T-shirt order form
All fields are required and validated