ITP London Jan 2025| Samunta Sunuwar |Module Onboarding | Form Controls|WEEK 2 #218
Conversation
…h due to lighthouse score
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Form-Controls/index.html
Outdated
| </select> | ||
| </p> | ||
| <p> | ||
| <label for="number">Please input quantity you would like to order:<strong><a aria-label="required">*</a></strong></label> |
There was a problem hiding this comment.
Quantity is not on the brief. Please remove it.
There was a problem hiding this comment.
Hi Waldo, thank you for your feedback, I have removed this
Form-Controls/index.html
Outdated
| <legend>Customer Details</legend> | ||
| <p> | ||
| <label for="name">Name:<strong><a aria-label="required">*</a></strong> | ||
| <input type="text" id="name" name="name" placeholder="Full Name" minlength="3" required> |
There was a problem hiding this comment.
You need to require at least 2 characters for the name field.
You also need to inform the user that their input is incorrect.
There was a problem hiding this comment.
@Waldo-Strydom Hi, thank you for the feedback. I have set the minlength to 2.
Please could you elaborate your second feedback "You also need to inform the user that their input is incorrect." I believe I have used correct validation for the form type="text" for Name and type="email" for email address. I am not sure how I can inform user their input is incorrect apart from using validation with HTML. Can you please point me in the direction of how I can achieve this.
There was a problem hiding this comment.
As an example it should look like this.
You can give each field a title, to communicate with users.
There was a problem hiding this comment.
Thank you for your advice, I have added the title attribute now. Please could you review.
Form-Controls/index.html
Outdated
| </p> | ||
| <p> | ||
| <label for="email">Email:<strong><a aria-label="required">*</a></strong> | ||
| <input type="email" id="email" name="email" placeholder="Email Address" required> |
There was a problem hiding this comment.
You also need to inform the user that their input is incorrect.
There was a problem hiding this comment.
Thank you for your advice, I have added the title attribute now. Please could you review.
|
Please add your cohort name e.g South Africa to your PR Titles. |
Waldo-Strydom
added
👀 Review Requirements
Samunta
changed the title
Samunta
added
Needs Review
Self checklist