Glasgow, ITP - Jan 25|CHRISTELLE BOTEN| Onboarding Wireframe| WEEK 1 #195
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Christelle-b
changed the title
| </p> | ||
| <p> | ||
| <label for="colour"> What colour should this T-shirt be? </label> <br> | ||
| <input type="radio" id="green" name="Tshirt_colour" value="Green"> |
There was a problem hiding this comment.
Please, avoid using capital letters in your attributes. Only lowercase letters and hyphens is the preferred way to code.
| <label for="yellow"> Yellow</label> | ||
| </p> | ||
| <p> | ||
| <label for="size"> Please choose a size. </label><br> |
There was a problem hiding this comment.
Your labels in inputs below are not connected correctly. Please, think what should correctly connect label with input.
There was a problem hiding this comment.
Never mind, your input was before the label and hence my concussion. All good. Just on line 35 I don't think you need for attribute or label tag. But it is minor issue.
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <h2>By CHRISTELLE BOTEN</h2> |
There was a problem hiding this comment.
I don't think that heading level 2 is appropriate semantic tag here. Please think of a better tag for this case.
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <h2>Read.Me FIle</h2> | ||
| <h3>Article summary</summary></h3> |
There was a problem hiding this comment.
I don't see opening <summary> tag in your code, only closing.
| </article> | ||
|
|
||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
I think the idea is to replace any image like 'placeholder'. I can suggest using unsplash for free images.
tyzia
added
Reviewed
Glasgow, ITP - Jan 25|CHRISTELLE BOTEN| Onboarding Wireframe| WEEK 1
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.