CYF-LONDON | Giosef Ferraro | HTML-CSS-Module | Week1 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SallyMcGrath
added
the
Review in progress
SallyMcGrath
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Hi @Giosef92 thanks for this!
- Please title your PR as everyone else has - take a look on the PR list on this repo.
- You have written a LOT of CSS here. As I read through it, it seems like you could delete quite a lot of it. This programme isn't focused on CSS, or front end, but it is focused on testing our code and writing high quality code.
With this in mind, please go through your CSS -- you can use this branch preview if you like https://deploy-preview-185--cyf-onboarding-module.netlify.app/wireframe/
And find me 20 lines you could delete. And then delete them! :) For extra value, tell me why you could delete them and how you figured this out.
Hint, I would start with some of these width rules. Good luck!
SallyMcGrath
added
Reviewed
- Removed redundant styles and fixed inconsistent indentation. - Optimized header padding declaration. - Fixed layout issues in .articles and .sub-article links. - Improved responsiveness and removed unnecessary media queries. - Ensured consistent styling in footer and images.
Giosef92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CYF-LONDON | Giosef Ferraro | HTML-CSS-Module | Week1
Complete the task list below this message.
If your PR is rejected, check the task list.
Learners, PR Template
Self checklist
Changelist