LONDON-JAN-25 | MIKIYAS GEBREMICHAEL| MODULE-ONBOARDING- Form/wireframe | WEEK 2 #180
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mikiyas-STP
changed the title
Form-Controls/index.html
Outdated
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <!DOCTYPE html> |
There was a problem hiding this comment.
Your html structure is wrong here. Please, update it. You are in the middle of a html doc, but <!DOCTYPE html> is always the very first element you see in the html.
Form-Controls/index.html
Outdated
| <body> | ||
| <div class="big-room"> | ||
| <h2>Customer Information</h2> | ||
| <form action="submit-form.php" method="POST"> |
There was a problem hiding this comment.
I don't see submit-form.php in your project. Please use actin="#" which is a convention to say "as for now we don't care where this form is submitted"
There was a problem hiding this comment.
the mistake was done while copy pasting my html code from my first branch to my second branch to make it work. this was done in class room as suggested by the mentor. but when pasting it inside html of the second branch which is form/wireframe i put it in wrong place. THANK YOU TYZIA for commenting it out. now i fixed it.
Form-Controls/index.html
Outdated
| </form> | ||
| </main> | ||
| <footer> | ||
| <h2>By Mikiyas Gebremichael</h2> |
There was a problem hiding this comment.
I don't think that heading level 2 is appropriate here. Please use other tag.
tyzia
added
Reviewed
Mikiyas-STP
added
Needs Review
|
Thank you for the update. Your work is complete. |
tyzia
added
Complete
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.