Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/wireframe #177

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Feature/wireframe #177

wants to merge 23 commits into from

Conversation

Rueimadut
Copy link

@Rueimadut Rueimadut commented Jan 18, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I have completed the wireframe and my code is ready for review

Questions

Ask any questions you have for your reviewer.

@Rueimadut
added definition of a branch
fa6a010
@Rueimadut
added definition of READ ME file
6853a25
@Rueimadut
added what is the purpose of a wireframe
6ec87fc
@Rueimadut
added the definition of a wireframe
a1d59ff
@Rueimadut
made some changes to the definition of a wireframe
254a363
@Rueimadut
changed the purpose of a wireframe
3f75a00
@Rueimadut
made some changes to purpose of a readme file
7d21354
@Rueimadut
added a link to purpose of a wireframe
c3da28a
@Rueimadut
added a link to purpose of a readme file
7df0e12
@Rueimadut
added a link to definition of a branch
d3888e6
@Rueimadut
added an image of a wireframe
2822ec0
@Rueimadut
added images of readme and a branch
c40b25a
@Rueimadut
added a footer paragraph
1c1ecbd
@Rueimadut
made some changes to the footer
9fa9bc1
@Rueimadut
made changes to background color
149929e
@Rueimadut
removed the boarder of the link
d032e4b
@Rueimadut
added boarder radius
421ecc8
@Rueimadut
added a box shadow
35d137d
@Rueimadut
made some changes to h1
3257cb4
@Rueimadut
committed some changes to the paragraph
05f8279
@Rueimadut
made some changes to the images
dccfe98
@Rueimadut
committed changes of the footer
5011dea
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 7a55b7e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/6791f9e16a66350008ecc2f7
😎 Deploy Preview https://deploy-preview-177--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rueimadut Rueimadut added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Participant to add when requesting review labels Jan 18, 2025
tyzia
tyzia reviewed Jan 18, 2025
View reviewed changes
Wireframe/index.html Outdated Show resolved Hide resolved
@tyzia tyzia removed the Needs Review Participant to add when requesting review label Jan 18, 2025
@tyzia tyzia added the Reviewed Volunteer to add when completing a review label Jan 18, 2025
Rueimadut
Rueimadut commented Jan 23, 2025
View reviewed changes
Copy link
Author

@Rueimadut Rueimadut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the issues.

@Rueimadut Rueimadut added the Complete Participant to add when work is complete and review comments have been addressed label Jan 23, 2025
@Rueimadut Rueimadut mentioned this pull request Jan 23, 2025
Open
@tyzia
Copy link

tyzia commented Jan 25, 2025

Thank you for the update. Your work is complete.

@tyzia tyzia removed the Reviewed Volunteer to add when completing a review label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyzia tyzia tyzia left review comments

@halilibrahimcelik halilibrahimcelik Awaiting requested review from halilibrahimcelik

@SallyMcGrath SallyMcGrath Awaiting requested review from SallyMcGrath

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed 📅 Sprint 1 Assigned during Sprint 1 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rueimadut @tyzia