hotfix: unclosed a on index.html #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's my vscode eating my tags again
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
illicitonion
approved these changes
Jan 13, 2025
Member
|
Yeah, we probably want to host two sites for the different directories, I guess :( And ideally only trigger each preview if that folder was actually modified. Sigh... |
Member
Author
Actually I think https://github.com/netlify/netlify-plugin-lighthouse?tab=readme-ov-file#lighthouse-plugin-configuration-options we can set it to those two files! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's my vscode eating my tags again
@illicitonion the lighthouse is running on the index.html. We will have to deploy each folder separately to get it to run on both projects, annoyingly.
The 93% is an unclosed a which has crept in somewhere. My VScode sometimes eats tags like this - it's annoying.