Skip to content

Manchester | ITP Jan-2026 | Ofonime Edak| Sprint 2 | Form Control #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ofonimeedak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Manchester | ITP Jan-2026 | Ofonime Edak| Sprint 2 | Form Control #1057

Ofonimeedak wants to merge 2 commits into from
+54 −10

Conversation

@Ofonimeedak
Copy link

@Ofonimeedak Ofonimeedak commented Jan 24, 2026 •
edited
Loading

Self checklist

  • [x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Form control using HTML only, to create a form for a T-shirt vendor

@github-actions

This comment has been minimized.

Sign in to view
@netlify
Copy link

netlify bot commented Jan 24, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit eda1c44
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69812ca47f3c1e0008c299bf
😎 Deploy Preview https://deploy-preview-1057--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Ofonimeedak Ofonimeedak added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@Ofonimeedak Ofonimeedak mentioned this pull request Jan 27, 2026
Open
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 2, 2026
cjyuan
cjyuan reviewed Feb 2, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • Have you tried submitting the form to ensure it behaves as expected?

    • If any value is omitted, the form won't submit
    • If all input are valid, then the form can be submitted successfully

  • Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?

Form-Controls/index.html Outdated
Comment on lines 51 to 57
<select name="size" id="size">
<option value="xs">XS</option>
<option value="s">S</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
Copy link
Contributor

@cjyuan cjyuan Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Spec asks for 6 different sizes.

  • There is a way to configure a <select> element so that no option is selected by default, allowing the user to make an explicit choice.

Copy link
Author

@Ofonimeedak Ofonimeedak Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, Cjyuan, for your feedback. I have done the correction, but I think checking the validator is not working because the URL is not public, and the github Url contains other HTML files

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 2, 2026
Ofonimeedak
Ofonimeedak commented Feb 2, 2026
View reviewed changes
Copy link
Author

@Ofonimeedak Ofonimeedak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated

@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ofonimeedak @cjyuan