This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
NW6 | Fikret Ellek | JS-2-Module | Week-1 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Great work @fikretellek !
Have a look at the feedback I left for your and try to implement them here and use it in your next tasks.
Thanks
| } else { | ||
| median = (sortedList[middleIndex] + sortedList[middleIndex - 1]) / 2; | ||
| } | ||
|
|
||
| return median; |
| return list; | ||
| } else { | ||
| let dedupedList = []; | ||
| for (let x of list) { |
There was a problem hiding this comment.
Can you please rename the x variable with a meaningful name?
| function maxNum(list) { | ||
| let maximum = -Infinity; | ||
| for (let x of list) { | ||
| if (x > maximum && !x.isNaN) { |
There was a problem hiding this comment.
Also, x is not really useful you should make all your functions and variables more meaningful.
| if (list.length === 0) { | ||
| return 0; | ||
| } else { | ||
| let sumOfNum = 0; |
There was a problem hiding this comment.
Is good practice to declare your variables at the top at the beginning of the function. SO can you remove the sumOfNum var to line 2?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Week 1's work is done.
Questions
Ask any questions you have for your reviewer.