This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
NW6 | Pedram Amani | JS2-Module | Week1 #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| } else { | ||
| return sortedList[middleIndex]; | ||
| } | ||
| // const median = list.splice(middleIndex, 1)[0]; |
There was a problem hiding this comment.
Great job, you can remove these lines since it is not useful?
Is not good practice to push commented code.
|
|
||
| console.log(dedupe(["a", "a", "a", "b", "b", "c"])); | ||
|
|
||
| module.exports = dedupe; |
| @@ -0,0 +1,5 @@ | |||
| function findMax(numbers) { | |||
| return Math.max(...numbers.filter((item) => typeof item === "number")); | |||
| } | |||
| 0 | ||
| ); | ||
| } | ||
|
|
| // } | ||
| // } | ||
| // return -1; | ||
| // } |
There was a problem hiding this comment.
Also, can you remove the commented code since you don't need it ?
Cheers mate! Thanks for your time! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
JavaScript2 - week1 exercises
Questions
Ask any questions you have for your reviewer.