West Midlands | 26-Jan-ITP | Fida Ali Zada | Sprint 3 | Quote Generator App#989
Open
alizada-dev wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
West Midlands | 26-Jan-ITP | Fida Ali Zada | Sprint 3 | Quote Generator App#989alizada-dev wants to merge 5 commits intoCodeYourFuture:mainfrom
alizada-dev wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
alizada-dev
added
the
Needs Review
A-O-Emmanuel
added
Review in progress
A-O-Emmanuel
left a comment
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
Your Quote generator app, works well. Adding an auto play button is a nice addition, one thing I will like to point is comments make a habit of adding them where appropriate, not line by line, but when you have a function, adding a comment of what the function does, is good practice, good job!
A-O-Emmanuel
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I didn't use AI to write the JavaScript code until after I finished writing the JS, but I did use AI for the CSS styling.