Skip to content

London | 26-ITP-Jan | Kris Oldrini | Sprint 3 | Quote Generator#1187

Open
XiaoQuark wants to merge 5 commits intoCodeYourFuture:mainfrom
XiaoQuark:51-build-a-quote-generator-app
Open

London | 26-ITP-Jan | Kris Oldrini | Sprint 3 | Quote Generator#1187
XiaoQuark wants to merge 5 commits intoCodeYourFuture:mainfrom
XiaoQuark:51-build-a-quote-generator-app

Conversation

@XiaoQuark
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implemented the quote generator functionality and added styling to improve the UI.

  • Updated the page title in index.html to Quote Generator App
  • Implemented logic in quotes.js to display a random quote and author when the page loads
  • Added an event listener to the New Quote button to display another random quote when clicked
  • Used the provided pickFromArray() function to select a random quote from the quotes array keeping selecting and rendering responsibilities separate.
  • Added custom CSS to style the page, including a centred quote card layout and improved button styling
  • Added decorative quotation marks around the quote to enhance the design

Tested changes by:

  • Running the Jest tests successfully
  • Checking in the browser that a random quote appears on load and updates correctly when the button is clicked
  • Running a Lighthouse audit and achieving 100 for accessibility

@XiaoQuark XiaoQuark added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants