-
-
Notifications
You must be signed in to change notification settings - Fork 278
London | 26-ITP-Jan | Alex Okorefe | Sprint 3 | Alarm clock #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alex-Os-Dev-Lab
wants to merge
4
commits into
CodeYourFuture:main
Choose a base branch
from
Alex-Os-Dev-Lab:alarm-clock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−3
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f55cbf8
Changed the title to Alarm Clock App
Alex-Os-Dev-Lab 333486d
Revert title to default in index.html
Alex-Os-Dev-Lab 1d5456c
Implement alarm functionality with countdown and validation
Alex-Os-Dev-Lab 457ae35
Refactor updateTimeDisplay function for clarity and consistency
Alex-Os-Dev-Lab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,48 @@ | ||
| function setAlarm() {} | ||
| timerInterval = null; | ||
| function setAlarm() { | ||
| // 1. Get the input from the user | ||
| const inputField = document.getElementById("alarmSet"); | ||
| let timeRemaining = parseInt(inputField.value); | ||
|
|
||
| // 2. Validate: If no number or 0 is entered, do nothing | ||
| if (isNaN(timeRemaining) || timeRemaining <= 0) { | ||
| return; | ||
| } | ||
|
|
||
| // 3. Clear any existing timer; prevent multiple alarms running at once | ||
| clearInterval(timerInterval); | ||
|
|
||
| // 4. Update the display immediately | ||
| updateTimeDisplay(timeRemaining); | ||
|
|
||
| // 5. Start the countdown | ||
| timerInterval = setInterval(() => { | ||
| timeRemaining -= 1; | ||
|
|
||
| updateTimeDisplay(timeRemaining); | ||
|
|
||
| // 6. Check if timer hit zero | ||
| if (timeRemaining <= 0) { | ||
| clearInterval(timerInterval); | ||
| playAlarm(); | ||
| document.body.style.backgroundColor = "red"; | ||
| } | ||
| }, 1000); | ||
| } | ||
|
Comment on lines
+2
to
+31
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you also reset the background colour when "Set Alarm" is clicked again after the timer is up? Right now it stays red, and resetting it would make the UI clearer for the next countdown. |
||
|
|
||
| // mm:ss formatting | ||
| function updateTimeDisplay(totalSeconds) { | ||
| const minutes = Math.floor(totalSeconds / 60); | ||
| const seconds = totalSeconds % 60; | ||
|
|
||
| //00:00 format | ||
| const formattedMinutes = minutes.toString().padStart(2, "0"); | ||
| const formattedSeconds = seconds.toString().padStart(2, "0"); | ||
|
|
||
| const timeString = `${formattedMinutes}:${formattedSeconds}`; | ||
| document.getElementById("timeRemaining").innerText = | ||
| `Time Remaining: ${timeString}`; | ||
| } | ||
|
|
||
| // DO NOT EDIT BELOW HERE | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To align with best practices, could we use a keyword here when initialising the variable?