Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 3 | Alarm Clock

[Seti-Jemal]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I have completed sprint 3 alarm clock.

[cjyuan]

• Given a countdown is still active, when the users click the "Set Alarm" button with input equals to 0, then what do you expect the app to behave?

• While a countdown is active, does the timer display look normal to you?

---

Note: We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a reason. If you are curious about why, you can ask AI Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file? (You have made some major changes to the original code, so don't worry about that this time).

[cjyuan]

Why not include a parameter to

• make this function reusable (e.g. call updateDisplay(0) to reset timer display)
• avoid using a global variable timeRemaining

?

[cjyuan]

To better separate presentation logic from application logic, you can consider defining a CSS class, and use classList.toggle() to apply/remove the style. For example,

document.body.classList.toggle("alarm-activated", true);  // apply style
document.body.classList.toggle("alarm-activated", false); // remove style

[cjyuan]

Currently when starting a new countdown, the application does not always return to a clean initial state,
which can lead to inconsistent behaviour between runs.

Hint: a user may not click the "Stop" button first before starting a new count down.