Glasgow - Class 06 - nasir ali - JS3 Challenges#10
Glasgow - Class 06 - nasir ali - JS3 Challenges#10ali-nasir-ali wants to merge 2 commits intoCodeYourFuture:masterfrom
Conversation
malkitbenning
left a comment
malkitbenning
left a comment
There was a problem hiding this comment.
Great coding Nasir! You have completed more than the mandatory requirement, and you have done it neatly and with clear code that is not wasteful of overly complicated. Very logical thinking applied, and good use of the utilities we have been taught. I expected nothing less!
| // 1. Accept arguments | ||
|
|
||
| // how will you accept arguments? | ||
| const args = process.argv.slice(2); |
|
|
||
| // how will you make the speech bubble contain the text? | ||
| const speechLength = saying.length + 2; | ||
| const speechBubble = `${topLine.repeat(speechLength)} |
There was a problem hiding this comment.
I like that you used the repeat function here
| // 1. Make a command line interface. | ||
| const readline = require("readline"); | ||
|
|
||
| // Create a readline interface |
There was a problem hiding this comment.
good use of readline to capture input
| @@ -1,49 +1,48 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
looks like an auto format has changed every line of the file so it's difficult to compare what was there before and your changes. Possibly switch off the auto-formatting in VS code?
| @@ -0,0 +1,92 @@ | |||
| const oWkey = "88642340ea796944c983a55632f5db1e"; | |||
There was a problem hiding this comment.
I've hidden my keys by not including them in the upload file - to keep them private.
| const { description, images } = await fetchData(city); | ||
| updateUI(description, images); | ||
| } catch (error) { | ||
| console.error("Error fetching data:", error); |
There was a problem hiding this comment.
good to see you've trapped errors
| cityNameCoordinates("glasgow"); | ||
| }; | ||
|
|
||
| async function cityNameCoordinates(city) { |
There was a problem hiding this comment.
using advanced async await! - good job
| thumb.classList.remove("active"); | ||
| }); | ||
|
|
||
| e.target.classList.add("active"); |
2 participants
No description provided.