Skip to content
This repository was archived by the owner on Oct 26, 2020. It is now read-only.

Deniz JS Week 1 Mandatory #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DenizAri
Copy link

@DenizAri DenizAri commented Jun 15, 2020

Did syntax logics errrors' function output and still need to work on tax

Your Details

Your Name: Deniz Ari
Your City:Birmingham
Your Slack Name:Deniz Ari

Homework Details

Module:JAVASCRIPT
Week:1

DenizAri added 4 commits June 15, 2020 20:01
Did syntax logics errrors' function output and still need to work on tax
@EmilePW EmilePW self-requested a review July 3, 2020 16:16
Copy link

@EmilePW EmilePW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Deniz, overall this is a good attempt at the JS 1 homework. I think you understand most of the concepts quite well. There were a few bits missing (or sometimes duplicated) which I've made notes of below - overall though I think that you are getting most of the concepts. One small thing is to be careful with the formatting of your code; things like +, /, etc. should have a space on either side and be careful to check that your variable, function and parameter names correspond to the values they are supposed to represent e.g. if a function is supposed to make use of a name, the parameter should be called 'name' or something similar.

I think that functions and methods may be the thing you are most unsure about? Let me know if you have any specific (or unspecific) questions here and I'm happy to answer them.

Notes from the exercises:

1D) You should have used a string for the variable - be careful to check against the exercise. You still demonstrated understanding of how to use the typeof operator though so I haven't marked you down for this.

The first exercise from 1F) is missing and the .trim method hasn't been used in the second exercise. .trim is used on strings and removes any empty space from the start and end of the string. e.g. " hello ".trim() becomes "hello". Let me know if you are having trouble with this.

1G) is the wrong exercise - it looks like you have 1I) done twice instead? I think you understand the material here though, seems like a mistake?

1K) - for the third exercise, you have named the parameters num1 and num2 - there should only be one parameter and it should be for the person's name.

1K) - the fifth exercise is missing (creating a long greeting) - let me know if you are having trouble with this.

1L) is missing. This requires both creating a function from scratch and using a string method (.toUpperCase() is the method to use).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants