This repository was archived by the owner on Jan 14, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 283
LND10 | Adrian Ilovan | JS1 Coursework Week3 #262
Open
AdrianIlovan
wants to merge
4
commits into
CodeYourFuture:main
Choose a base branch
from
AdrianIlovan:lnd10/adrianilovan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,40 @@ | ||
/* | ||
Imagine you are working on the Financial Times web site! They have a list of article titles stored in an array. | ||
Imagine you are working on the Financial Times web site! | ||
They have a list of article titles stored in an array. | ||
|
||
The home page of the web site has a headline section, which only has space for article titles which are 65 characters or less. | ||
Implement the function below, which will return a new array containing only article titles which will fit. | ||
The home page of the web site has a headline section, | ||
which only has space for article titles which are 65 characters or less. | ||
Implement the function below, which will return a new array | ||
containing only article titles which will fit. | ||
*/ | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks very good 👍 |
||
function potentialHeadlines(allArticleTitles) { | ||
// TODO | ||
} | ||
let headline = []; | ||
for (let article of allArticleTitles) { | ||
if (article.length <= 65) { | ||
headline.push(article); | ||
} | ||
} | ||
return headline | ||
} | ||
|
||
|
||
/* | ||
The editor of the FT likes short headlines with only a few words! | ||
Implement the function below, which returns the title with the fewest words. | ||
(you can assume words will always be seperated by a space) | ||
*/ | ||
function titleWithFewestWords(allArticleTitles) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very good solution! |
||
// TODO | ||
let numberOfWords; | ||
let smallerTitle; | ||
for (let headlineTitle of allArticleTitles) { | ||
let titleSplit = headlineTitle.split(" ").length; | ||
if (titleSplit < numberOfWords || numberOfWords === undefined) { | ||
numberOfWords = titleSplit; | ||
smallerTitle = headlineTitle; | ||
} | ||
} | ||
return smallerTitle; | ||
} | ||
|
||
/* | ||
|
@@ -24,6 +44,13 @@ function titleWithFewestWords(allArticleTitles) { | |
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The next few exercises look good as well! |
||
function headlinesWithNumbers(allArticleTitles) { | ||
// TODO | ||
let arrayOfNumbers = []; | ||
for (article of allArticleTitles) { | ||
if (/\d/.test(article)) { | ||
arrayOfNumbers.push(article); | ||
} | ||
} | ||
return arrayOfNumbers; | ||
} | ||
|
||
/* | ||
|
@@ -32,10 +59,17 @@ function headlinesWithNumbers(allArticleTitles) { | |
*/ | ||
function averageNumberOfCharacters(allArticleTitles) { | ||
// TODO | ||
let totalCharacters = 0; | ||
for (let article of allArticleTitles) { | ||
totalCharacters += article.length; | ||
} | ||
return Math.round(totalCharacters / allArticleTitles.length); | ||
} | ||
|
||
|
||
|
||
|
||
|
||
/* ======= List of Articles - DO NOT MODIFY ===== */ | ||
const ARTICLE_TITLES = [ | ||
"Streaming wars drive media groups to spend more than $100bn on new content", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👍