This repository was archived by the owner on Jan 14, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 609
London class 10 - Iryna Lypnyk - HTML-CSS-Coursework-Week3 #526
Open
IrynaLypnyk
wants to merge
5
commits into
CodeYourFuture:master
Choose a base branch
from
IrynaLypnyk:london-class-10/iryna-lypnyk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,12 +5,94 @@ | |
<meta charset="UTF-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<meta http-equiv="X-UA-Compatible" content="ie=edge"> | ||
<link rel="preconnect" href="https://fonts.googleapis.com"> | ||
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
<link href="https://fonts.googleapis.com/css2?family=Gwendolyn&family=Open+Sans:wght@300;500&display=swap" | ||
rel="stylesheet"> | ||
<link rel="stylesheet" href="style.css"> | ||
<title>Responsive Cake webpage</title> | ||
<!-- Add a link to your css file here --> | ||
</head> | ||
|
||
<body> | ||
<!-- Add your markup here --> | ||
<div class="wrapper"> | ||
<header class="header"> | ||
<nav class="menu"> | ||
<div class="menu_icon"> | ||
<span></span> | ||
<span></span> | ||
<span></span> | ||
</div> | ||
Comment on lines
+19
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice custom hamburger menu icon! 👍 |
||
<ul class="menu_list"> | ||
<li class="menu_item active"> | ||
<a href="#">Home</a> | ||
</li> | ||
<li class="menu_item"> | ||
<a href="#">Cakes</a> | ||
</li> | ||
<li class="menu_item"> | ||
<a href="#">Ordering</a> | ||
</li> | ||
<li class="menu_item"> | ||
<a href="#">Lessons</a> | ||
</li> | ||
<li class="menu_item"> | ||
<a href="#">About</a> | ||
</li> | ||
</ul> | ||
</nav> | ||
</header> | ||
<section class="welcome"> | ||
<div class="content content--welcome"> | ||
<div class="welcome_img"> | ||
</div> | ||
<h1 class="welcome_title"> | ||
The best cake in town delivered to your door | ||
</h1> | ||
</div> | ||
</section> | ||
<section class="about content"> | ||
<div class="about_text content"> | ||
<h2 class="section_title">Welcome</h2> | ||
<p> Lorem ipsum dolor sit amet, consectetur adipisicing elit. Accusamus dolorum et exercitationem | ||
molestiae nostrum perferendis porro possimus reiciendis reprehenderit vitae</p> | ||
</div> | ||
<div class="about_img"></div> | ||
</section> | ||
<section class="gallery content"> | ||
<ul class="gallery_list"> | ||
<li class="gallery_item"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For all your lists, you can make the css less brittle and html more terse by removing the class on the items themselves and just select the immediate list items.
If you are particularly concerned about nested lists then
Should guard the drop-down should guard you against that. |
||
<img src="images/gallery_1.webp" alt=""> | ||
</li> | ||
<li class="gallery_item"> | ||
<img src="images/gallery_2.webp" alt=""> | ||
</li> | ||
<li class="gallery_item"> | ||
<img src="images/gallery_3.webp" alt=""> | ||
</li> | ||
<li class="gallery_item"> | ||
<img src="images/gallery_4.webp" alt=""> | ||
</li> | ||
</ul> | ||
</section> | ||
<footer class="footer"> | ||
<div class="socials content"> | ||
<h3 class="section_subtitle">Connect</h3> | ||
<ul class="socials_list"> | ||
<li class="socials_item"> | ||
<a href="#">Instagram</a> | ||
</li> | ||
<li class="socials_item"> | ||
<a href="#">Facebook</a> | ||
</li> | ||
<li class="socials_item"> | ||
<a href="#">Telegram</a> | ||
</li> | ||
</ul> | ||
</div> | ||
<p class="footer_copyright">Made with love by Iryna Lypnyk</p> | ||
</footer> | ||
</div> | ||
|
||
|
||
</body> | ||
|
||
</html> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For accessibility, you should probably make this a
<button>
. That way screen readers identify it as such.