This repository was archived by the owner on Jan 14, 2024. It is now read-only.
LONDON CLASS _8-DONA_SHEHU-HTML/CSS-WEEK_3 #276
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,204 @@ | ||
|
|
||
| .body{ | ||
| display:grid; | ||
| grid-template-columns: repeat(4, 1fr); | ||
| grid-template-rows: auto; | ||
| grid-template-areas: | ||
|
|
||
| "header header header header" | ||
| "main main main main" | ||
| "footer footer footer footer"; | ||
| } | ||
|
|
||
| /***HEADER***/ | ||
| .header { | ||
| grid-area: header; | ||
| background-color:rgb(245, 233, 245) ; | ||
| } | ||
| .homepage-header { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| padding:15px; | ||
| } | ||
| .logo-img { | ||
| width: 50%; | ||
|
There was a problem hiding this comment. Using % for width shows how great your understanding of CSS is |
||
| height: 50%; | ||
| border-radius:80%; | ||
| object-fit: cover; | ||
|
|
||
| } | ||
| .hamburger-logo { | ||
| width: 60px; | ||
| height: 40px; | ||
| } | ||
| .header-p { | ||
| font-family:system-ui; | ||
| color:rebeccapurple; | ||
| font-size: 20px; | ||
| margin: 50px 20px 0 0 ; | ||
| text-align: right; | ||
| } | ||
| .nav-bar { | ||
| display: none;; | ||
| } | ||
| /***MAIN**/ | ||
| .main { | ||
| grid-area: main; | ||
| } | ||
|
|
||
| /****WELCOME & PARAGRAPH***/ | ||
| .homepage-welcome { | ||
| margin-bottom: 50px; | ||
| } | ||
| .homepage-welcome h1 { | ||
| font-size: 50px; | ||
| color:rebeccapurple; | ||
| text-shadow: 0 0 3px #FF0000, 0 0 5px #0000FF; | ||
| } | ||
| .homepage-welcome p { | ||
| font-size:30px; | ||
| } | ||
|
|
||
| /***HERO***/ | ||
| .homepage-hero img { | ||
| width:100%; | ||
| } | ||
| .homepage-hero { | ||
| margin-bottom: 50px; | ||
| } | ||
|
|
||
| /***PRODUCTS***/ | ||
| .homepage-products { | ||
| display: grid; | ||
| grid-template-columns:repeat(2,1fr); | ||
| grid-template-rows: 200px 200px; | ||
| grid-gap:30px; | ||
| padding: 0 20px; | ||
| margin-bottom: 100px; | ||
| } | ||
| .products,figcaption { | ||
| text-align: center; | ||
| font-size:15px; | ||
| font-weight: bold; | ||
| color:black | ||
| } | ||
| .products img { | ||
| width:100%; | ||
|
There was a problem hiding this comment. yes thats correct! having 100% width and height applied to the image(s), those images will then try to fit whatever width of the div that wrap them. I would do exactly the same to achieve responsiveness |
||
| height:100%; | ||
| object-fit: cover; | ||
| border-radius: 35px; | ||
| border: 3px solid rgb(226, 213, 213); | ||
| } | ||
| /***FOOTER***/ | ||
| .footer { | ||
| grid-area: footer; | ||
| } | ||
| .homepage-footer { | ||
| font-size: 25px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| margin-bottom: 50px; | ||
| } | ||
| .homepage-footer a { | ||
| text-decoration: none; | ||
| margin-bottom: 10px; | ||
|
|
||
| } | ||
| .copy-right { | ||
| text-align: center; | ||
| } | ||
| /* TABLET VERSION*/ | ||
| @media screen and (min-width: 550px) { | ||
|
There was a problem hiding this comment. Was this break point not supposed to start at 540px? There was a problem hiding this comment. I believe the homework mentions only 2 breakpoints: 540px and 900px! |
||
| .homepage-header { | ||
| margin-top: 50px 0; | ||
| display: flex; | ||
| justify-content: space-between; | ||
|
|
||
| } | ||
| .header-p { | ||
| font-size: 30px; | ||
| text-align: center; | ||
| padding-bottom: 40px; | ||
| } | ||
| .hamburger-logo { | ||
| width: 80px; | ||
| height: 60px; | ||
| text-align: right; | ||
| } | ||
| .homepage-welcome p { | ||
| font-size:30px; | ||
| } | ||
| .homepage-header .logo-img { | ||
|
There was a problem hiding this comment. Great way of avoiding code repetition |
||
| width: 50%; | ||
| height: 50%; | ||
| border-radius:70%; | ||
| object-fit: cover; | ||
| } | ||
|
|
||
| .homepage-products { | ||
| display: grid; | ||
| grid-template-columns:repeat(2,1fr); | ||
| grid-template-rows: 250px 250px; | ||
| grid-gap:30px; | ||
| padding: 0 20px; | ||
| margin-bottom: 100px; | ||
| } | ||
| } | ||
|
|
||
| @media screen and (min-width:900px) { | ||
| .homepage-products { | ||
| display: grid; | ||
| grid-template-columns:repeat(4,1fr); | ||
| grid-template-rows:auto | ||
| } | ||
|
|
||
| .homepage-welcome { | ||
| width:50%; | ||
| text-align: left; | ||
| padding:0 30px; | ||
| } | ||
| .homepage-hero { | ||
| width:50%; | ||
| } | ||
| .homepage-products { | ||
| display: flex; | ||
| justify-content: space-evenly; | ||
| } | ||
| .change-position { | ||
| padding: 0 30px; | ||
| display: flex; | ||
| flex-direction: row-reverse; | ||
| justify-content: center; | ||
| } | ||
| .hamburger-logo img { | ||
| display:none; | ||
| } | ||
| .nav-bar { | ||
| display:block; | ||
| font-size: 22px; | ||
| margin-bottom: 50px; | ||
| padding-right: 30px; | ||
| } | ||
| .nav-bar ul { | ||
| display: flex; | ||
| list-style: none; | ||
| text-decoration: none; | ||
| justify-content: flex-end; | ||
| } | ||
| .nav-bar a { | ||
| text-decoration: none; | ||
| padding: 15px; | ||
| } | ||
| .products { | ||
| width: 250px; | ||
| height: 250px; | ||
| object-fit: cover; | ||
| } | ||
| .homepage-footer { | ||
| display: flex; | ||
| } | ||
| .homepage-footer { | ||
|
There was a problem hiding this comment. footer should be aligned in one row instead of 3 rows for desktop view |
||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-evenly; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the indentation in this document is properly done please :)