This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London/8-Mahri-Atdayeva-responsive-cake-webpage-week3 #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikanengKhoza
reviewed
Dec 7, 2021
| <link rel="stylesheet" href="./css/style.css" /> | ||
| <link rel="stylesheet" href="./css/header.css" /> | ||
| <link rel="stylesheet" href="./css/footer.css" /> |
There was a problem hiding this comment.
Great work Mahri, I like your approach of creating different style sheets for different sections. Well done!
| <label for="hamburger">☰</label> | ||
| <input type="checkbox" id="hamburger-input" /> | ||
| </div> |
There was a problem hiding this comment.
This is great Manhri, my TA suggested using an image rather than code because the css is shorter. She explained that the shorter the code the better.
|
Thank you Ika. I am happy for doing progress!
…Sent from my iPhone
On 7 Dec 2021, at 13:46, ikanengKhoza ***@***.***> wrote:
@ikanengKhoza commented on this pull request.
In index.html:
> \ No newline at end of file
+ <link rel="stylesheet" href="./css/style.css" />
+ <link rel="stylesheet" href="./css/header.css" />
+ <link rel="stylesheet" href="./css/footer.css" />
Great work Mahri, I like your approach of creating different style sheets for different sections. Well done!
In index.html:
> + </head>
+ <body>
+ <div class="container">
+ <header>
+ <div class="header-logo">
+ <img
+ src="./images/images.png"
+ id="logo-image"
+ alt="logo-image-unicorn"
+ />
+ </div>
+ <div class="header-wrapper">
+ <div class="hamburger">
+ <label for="hamburger">☰</label>
+ <input type="checkbox" id="hamburger-input" />
+ </div>
This is great Manhri, my TA suggested using an image rather than code because the css is shorter. She explained that the shorter the code the better.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?