This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London class 8/harsheek thanki #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jackhclee please see my homework attached for the cake shop site. Thanks |
jackhclee
reviewed
Dec 3, 2021
Comment on lines
+23
to
+27
| <img src="images/piece-of-cake.png" /> | ||
| <p>The best cakes in town delivered to your door</p> | ||
| <div class="burger"> | ||
| <img src="images/burger-menu.png" /> | ||
| </div> |
There was a problem hiding this comment.
Remember to provide alt to improve accessibility
jackhclee
reviewed
Dec 3, 2021
Comment on lines
+100
to
+105
| .products img { | ||
| border: 3px solid black; | ||
| border-radius: 20px; | ||
| width: 100%; | ||
| padding: 10px; | ||
| } |
There was a problem hiding this comment.
consider using relative units instead of hardcoding in px?
jackhclee
reviewed
Dec 3, 2021
Comment on lines
+122
to
+124
| grid-area: "header header header header" "nav nav nav nav" | ||
| "image image welcome welcome" "products products products products" | ||
| "footer footer footer footer"; |
There was a problem hiding this comment.
improve readability by keeping rows at separate lines
jackhclee
reviewed
Dec 3, 2021
Comment on lines
+217
to
+222
| @media screen and (min-width: 900px) { | ||
| nav ul li { | ||
| margin: 0px 40px; | ||
| background-color: #ddbea9; | ||
| } | ||
| } |
There was a problem hiding this comment.
A well structured original work, well done! I see well coding practices and use of responsive media queries with confidence. Keep good work going!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
I am getting confident on how to structure a site using HTML divs and sections.
What did you find hard?
CSS grid, I feel like I'm still learning it
What do you still not understand?
How to horizontally align a CSS grid element
Any other notes?