Adding models when instantiating store crashes

[SpaceK33z]

Using this (assuming you have a store with a model):

new Store([{ id: 1 }]);

Will give:

TypeError: this.Model is not a constructor

This is because the constructor() in src/Store.js is executed before the child constructor can set this.Model. I have no idea yet how to fix this unfortunately.

There is a failing testcase (currently skipped) in src/__tests__/Store.js

[SpaceK33z]

It's basically this issue:

class Foo {
    constructor() {
        console.log('greeting:', this.greeting);
    }
}

class Bar extends Foo {
    greeting = 'hey';
}

new Bar();
// greeting: undefined

Also described here.

[SpaceK33z]

Discussed with Rob, there are two solutions, but both are kind of mweh:

• Add an initialize() method to models/stores, and allow the Model to be defined in there:

class AnimalStore extends Store {
  initialize() {
    this.Model = Animal;
  }
}

• Completely disallow immediately adding objects to the store (new Store(models)), and force to use new Store().parse()

[SpaceK33z]

Aand discussed with Burhan (it really looks like I'm a psychopath now), we're going for option 2. So the Store constructor will only accept one argument (options). If any of the properties in the options object are unknown, we should throw an error. Also if it is an array it should throw an error.