Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the JavaScript handling of Filament's modals and error notifications, as well as some internal refactoring for consistency and maintainability. The main focus is on enhancing the modal overlay behavior and providing better error notification handling for Livewire requests.
Key changes include:
Modal overlay handling:
syncActionModalsfunction inactions.jsto support a newshouldOverlayParentActionsparameter, allowing more precise control over modal stacking and overlay behavior.Error notification improvements:
app.jsthat displays customized Filament notifications based on the error status, improving user feedback for failed requests.Internal refactoring and consistency:
app.jsfor improved readability and maintainability, aligning naming conventions and structure across the codebase.