Add Ruby implementation for Day 6 problem; Add Ruby, C++ & Java implementations for Day 7 problem #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .all-contributorsrc # CONTRIBUTORS.md # Day1/README.md
added 7 commits
December 27, 2018 17:29
Member
|
Hey @aaditkamat looks like there are some merge conflicts, |
aaditkamat
changed the title
aaditkamat
changed the title
aaditkamat
changed the title
aaditkamat
changed the title
Author
|
Sorry for these extraneous change in titles, I was trying to format the title properly |
MadhavBahl
requested changes
Dec 29, 2018
Member
MadhavBahl
left a comment
MadhavBahl
left a comment
There was a problem hiding this comment.
Please check the README, some codes were removed,
it might be a case that someone's PR was accepted and after that you pushed your changes, I guess due to that some lines were removed.
Please fix it.
| * @author : dhruv-gupta14 | ||
| * @date : 27/12/2018 | ||
| */ | ||
| ```ruby |
Member
There was a problem hiding this comment.
Where are the @author and @date credits
| print("Reverse of string: ", reverse_words(string)}) | ||
| ``` | ||
|
|
||
| ## C++ Implementation |
Member
There was a problem hiding this comment.
Why did you remove the C++ implementation
| puts "\nAre #{first_str} and #{second_str} anagrams? #{check_anagram(String.new(first_str), String.new(second_str))}" | ||
| ``` | ||
|
|
||
| ### [Anagram Check by @imkaka](./C++/checkAnagram.cpp) |
| print("Reverse of string \'", string, "\': ", reverse_words(string), sep='') | ||
| ``` | ||
|
|
||
| ### [Word Reverse by @imkaka](./C++/wordReverse.cpp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure you have done the following:
/Day<n>/directory (Where n is for nth day)all-conributors-cli