Skip to content

Conversation

@d-l-mcbride
Copy link
Contributor

@d-l-mcbride d-l-mcbride commented Oct 12, 2020

Please make sure you have done the following:

  • Created a folder with the name of language you code inside directory for the day you are making the contribution to
  • Added the source code file inside /Day<n>/<Language>/
  • Tested your code
  • Added credits (author and date) at the top of the code
  • Updated README.md for /Day <n>/
  • Added yourself as a contributor using all-contributors-cli

@d-l-mcbride
Copy link
Contributor Author

Here is my new pull request. Sorry about the last one without pulling from this repo first :(

}
}

fizzBuzz((1..15).toList())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong, a top level declaration is required.

Suggested change
fizzBuzz((1..15).toList())
fun main() {
fizzBuzz((1..15).toList())
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Kotlin script file(.kts) stand alone functions work without the associated main function. I can make the change though.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case you can leave it as it is.

}
}
fizzBuzz((1..15).toList())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should reflect the change made in the source code file

Copy link

@aaditkamat aaditkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested some minor changes. Apart from those, I don't think any other amendments are required since the logic of the program is correct.

@aaditkamat aaditkamat self-requested a review October 15, 2020 13:37
Copy link

@aaditkamat aaditkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@aaditkamat aaditkamat merged commit 3c48b37 into CodeToExpress:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants