Skip to content

php day 1 implementation #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MadhavBahl merged 3 commits into from
Jan 16, 2019
Merged

php day 1 implementation #184

MadhavBahl merged 3 commits into from
Jan 16, 2019

Conversation

@willianwt
Copy link
Contributor

@willianwt willianwt commented Jan 16, 2019

Please make sure you have done the following:

  • Created a folder with the name of language you code inside /Day<n>/ directory (Where n is for nth day)
  • Added your Codes
  • Tested your codes
  • Added credits (author and date) at the top of the code
  • Updated README.md
  • Added yourself as a contributor using all-conributors-cli

@MadhavBahl
Copy link
Member

MadhavBahl commented Jan 16, 2019

LGTM 👍

Thanks for contributing @willianwt 😄

@MadhavBahl MadhavBahl merged commit 8f06c4d into CodeToExpress:master Jan 16, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jan 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@willianwt @MadhavBahl