Skip to content

solved previous days pending questions. #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Utkarshmalik wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solved previous days pending questions. #135

Utkarshmalik wants to merge 2 commits into from

Conversation

@Utkarshmalik
Copy link

@Utkarshmalik Utkarshmalik commented Jan 6, 2019

Please make sure you have done the following:

  • [ y] Created a folder with the name of language you code inside /Day<n>/ directory (Where n is for nth day)
  • [y] Added your Codes
  • [y] Tested your codes
  • [y] Added credits (author and date) at the top of the code
  • [y] Updated README.md
  • [y] Added yourself as a contributor using all-conributors-cli

MadhavBahl
MadhavBahl reviewed Jan 8, 2019
View reviewed changes
day4/README.md
}
```


Copy link
Member

@MadhavBahl MadhavBahl Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ```

MadhavBahl
MadhavBahl reviewed Jan 8, 2019
View reviewed changes
day4/README.md

}
}

Copy link
Member

@MadhavBahl MadhavBahl Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ```

MadhavBahl
MadhavBahl requested changes Jan 8, 2019
View reviewed changes
day6/C++/day6-1.cpp
@@ -0,0 +1,47 @@

Copy link
Member

@MadhavBahl MadhavBahl Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ```

for code snippet

day6/C++/day6-1.cpp

return 0;
}

Copy link
Member

@MadhavBahl MadhavBahl Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ```

to end code snippet in README.md

day7/C++/day-7.cpp
@@ -0,0 +1,112 @@
/**
Copy link
Member

@MadhavBahl MadhavBahl Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ```

day7/C++/day-7.cpp

//Time Complexity O(m+n) , where m,n are the size of the two input strings.


Copy link
Member

@MadhavBahl MadhavBahl Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ```

@MadhavBahl
Copy link
Member

MadhavBahl commented Jan 8, 2019

Please correct all README.md

@weekly-digest weekly-digest bot mentioned this pull request Jan 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MadhavBahl MadhavBahl MadhavBahl requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Utkarshmalik @MadhavBahl